Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate views, view containers, view locations #48535

Closed
sandy081 opened this issue Apr 24, 2018 · 1 comment
Closed

Consolidate views, view containers, view locations #48535

sandy081 opened this issue Apr 24, 2018 · 1 comment
Assignees
@sandy081
Labels
debt Code quality issues tree-views Extension tree view issues
Milestone
June 2018

Comments

@sandy081
Copy link
Member

sandy081 commented Apr 24, 2018 •
edited

Consolidate views, view containers, view locations

  • Do not leak viewlet ids directly
  • Merge view containers and view locations
  • Ability to get viewlet information from view descriptor

Fix following:

  • Register a custom view in SCM or Debug locations
  • When children are being fetched while opening a node, no progress is shown in the respective Viewlet.
@sandy081 sandy081 self-assigned this Apr 24, 2018
@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug tree-views Extension tree view issues labels Apr 24, 2018
@sandy081 sandy081 modified the milestones: April 2018, May 2018 Apr 24, 2018
@sandy081 sandy081 added debt Code quality issues and removed bug Issue identified by VS Code Team member as probable bug labels Apr 24, 2018
@sandy081
Copy link
Member Author

Moving this to May. There is a debt involved in handling viewlets, views, view locations and progress locations

sandy081 added a commit that referenced this issue Apr 24, 2018
@sandy081
#48535 Get progress location from view location
8aa6fe9
@sandy081 sandy081 changed the title Viewlet progress is not shown while expanding nodes in custom views in SCM and Debug Consolidate views, view containers, view locations Apr 25, 2018
@sandy081 sandy081 mentioned this issue Apr 25, 2018
Closed
@joaomoreno joaomoreno mentioned this issue May 2, 2018
Closed
4 tasks
@sandy081 sandy081 modified the milestones: May 2018, June 2018 May 2, 2018
sandy081 added a commit that referenced this issue Jun 4, 2018
@sandy081
#48535 Make views service generic
cb1d1f7
sandy081 added a commit that referenced this issue Jun 4, 2018
@sandy081
#48535 Merge contributable views model into views
c770689
sandy081 added a commit that referenced this issue Jun 5, 2018
@sandy081
#48535 Adopt to contributable views model
3cc954a
sandy081 added a commit that referenced this issue Jun 5, 2018
@sandy081
#48535 Check if views are there to add
b52cf26
sandy081 added a commit that referenced this issue Jun 5, 2018
@sandy081
#48535 Use scm viewlet id as location id
e2d5327
sandy081 added a commit that referenced this issue Jun 5, 2018
@sandy081
#48535 Use title instead of name
5913f18
sandy081 added a commit that referenced this issue Jun 6, 2018
@sandy081
#48535 SCM viewlet has unregistered views
fc6c30e
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
debt Code quality issues tree-views Extension tree view issues
Projects
None yet
Milestone
June 2018
Development

No branches or pull requests
1 participant
@sandy081