Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider to use modal alerts instead of error notifications #48538

Closed
weinand opened this issue Apr 24, 2018 · 1 comment
Closed

Consider to use modal alerts instead of error notifications #48538

weinand opened this issue Apr 24, 2018 · 1 comment
Assignees
@egamma

Comments

@weinand
Copy link
Contributor

weinand commented Apr 24, 2018 •
edited

testing #48354:

  • open NPM Scripts explorer
  • select an arbitrary script that is not meant for debugging
  • run "Debug" from context menu

Observe:
This error alert appears:
2018-04-24_14-07-26

On my large screen I missed this and wondered what was happening...

Since running the "Debug" action is initiated by the user, I suggest to use a modal alert that jumps into the user's face instead of "hiding" a notification in a corner.
@egamma
Copy link
Member

egamma commented Apr 24, 2018

Agreed that an alert would be better. However, Alerts currently do not have support for links.

egamma added a commit that referenced this issue Apr 25, 2018
@egamma
Fixing #48538 use modal alert for the error message
7cf5c29
@egamma egamma closed this as completed Apr 25, 2018
egamma added a commit that referenced this issue Apr 26, 2018
@egamma
Add a Learn More action fixing #48538
51a8803
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@egamma egamma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@egamma @weinand