Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getWorkspaceStats prints errors to console #48570

Closed
jrieken opened this issue Apr 24, 2018 · 3 comments
Closed

getWorkspaceStats prints errors to console #48570

jrieken opened this issue Apr 24, 2018 · 3 comments
Assignees
@ramya-rao-a
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
April 2018

Comments

@jrieken
Copy link
Member

jrieken commented Apr 24, 2018 •
edited

screen shot 2018-04-24 at 18 48 31

  ERR File not found (memfs:/package.json): Error: File not found (memfs:/package.json)
    at new FileOperationError (file:///Users/jrieken/Code/vscode/out/vs/platform/files/common/files.js:199:32)
    at file:///Users/jrieken/Code/vscode/out/vs/workbench/services/files/electron-browser/remoteFileService.js:279:31
    at Object.notifySuccess [as _notify] (file:///Users/jrieken/Code/vscode/out/vs/base/common/winjs.base.js:1185:59)
    at Object.enter (file:///Users/jrieken/Code/vscode/out/vs/base/common/winjs.base.js:867:30)
    at Promise_ctor._run (file:///Users/jrieken/Code/vscode/out/vs/base/common/winjs.base.js:1083:29)
    at Promise_ctor._completed (file:///Users/jrieken/Code/vscode/out/vs/base/common/winjs.base.js:1051:18)
    at argDone (file:///Users/jrieken/Code/vscode/out/vs/base/common/winjs.base.js:1828:37)
    at Promise.then.errors.(anonymous function) (file:///Users/jrieken/Code/vscode/out/vs/base/common/winjs.base.js:1853:78)
    at Object.notifySuccess [as _notify] (file:///Users/jrieken/Code/vscode/out/vs/base/common/winjs.base.js:1185:59)
    at Object.enter (file:///Users/jrieken/Code/vscode/out/vs/base/common/winjs.base.js:916:30)
    at Promise_ctor._run (file:///Users/jrieken/Code/vscode/out/vs/base/common/winjs.base.js:1083:29)
    at Promise_ctor._error (file:///Users/jrieken/Code/vscode/out/vs/base/common/winjs.base.js:1056:18)
    at LazyPromise.resolveErr (file:///Users/jrieken/Code/vscode/out/vs/workbench/services/extensions/node/lazyPromise.js:53:22)
    at RPCProtocol._receiveReplyErr (file:///Users/jrieken/Code/vscode/out/vs/workbench/services/extensions/node/rpcProtocol.js:196:26)
    at RPCProtocol._receiveOneMessage (file:///Users/jrieken/Code/vscode/out/vs/workbench/services/extensions/node/rpcProtocol.js:147:26)
@ramya-rao-a ramya-rao-a added the bug Issue identified by VS Code Team member as probable bug label Apr 26, 2018
@ramya-rao-a ramya-rao-a added this to the April 2018 milestone Apr 26, 2018
@jrieken
Copy link
Member Author

jrieken commented Apr 26, 2018 •
edited

screen shot 2018-04-26 at 10 36 21

Still happens, e.g. with files missing from disk. Also the fix doesn't seems correct because workspace folders are expected to live on remote places and simply ignoring those misses the point of workspace stats.

@jrieken jrieken reopened this Apr 26, 2018
@jrieken jrieken added the verification-found Issue verification failed label Apr 26, 2018
ramya-rao-a added a commit that referenced this issue Apr 26, 2018
@ramya-rao-a
Better fix for #48570 Ignore errors when resolving files to get works…
e89b895 
…pace stats
@ramya-rao-a
Copy link
Contributor

ramya-rao-a commented Apr 26, 2018 •
edited

Still happens, e.g. with files missing from disk.

I cant repro this with the current fix in place. We only look for contents of the package.json file if it was found when doing a resolveFiles on the workspace.

Also the fix doesn't seems correct because workspace folders are expected to live on remote places and simply ignoring those misses the point of workspace stats

Agreed, I have reverted the previous fix.

Current fix is to ignore the errors coming from resolveContent when fetching the file contents on the package.json file. This is consistent with the other 2 cases in the same file where we attempt to fetch file contents.

@ramya-rao-a ramya-rao-a removed the verification-found Issue verification failed label Apr 26, 2018
@chrmarti chrmarti mentioned this issue Apr 26, 2018
Closed
@chrmarti chrmarti added the verified Verification succeeded label Apr 27, 2018
@chrmarti
Copy link
Contributor

Missed that we dropped a check with resolveFile when reviewing #48296. Thanks @ramya-rao-a! /fyi @kieferrm

@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ramya-rao-a ramya-rao-a

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
April 2018
Development

No branches or pull requests
3 participants
@jrieken @chrmarti @ramya-rao-a