Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New view containers api has inconsistent naming #48583

Closed
sbatten opened this issue Apr 24, 2018 · 1 comment
Closed

New view containers api has inconsistent naming #48583

sbatten opened this issue Apr 24, 2018 · 1 comment
Assignees
@sandy081
Labels
polish Cleanup and polish issue tree-views Extension tree view issues verified Verification succeeded
Milestone
April 2018

Comments

@sbatten
Copy link
Member

sbatten commented Apr 24, 2018

Testing #48407

The new viewsContainers contribution point has inconsistent naming. The expected name appears to be viewsContainers while in a couple places in the code (which gets surfaced to the users confusingly in the debug console) we use viewsContainer. This also permeates inconsistently through the schema interface name viewsContainerSchema and the localization labels within it: ....views.containers...
@sandy081
Copy link
Member

@sbatten Good finding.

Regarding schema viewsContainerSchema - it is for single viewsContainer hence it is named like that. There is also schema for viewsContainers while internally refers to viewsContainerSchema`.

@sandy081 sandy081 added polish Cleanup and polish issue tree-views Extension tree view issues labels Apr 25, 2018
@sandy081 sandy081 added this to the April 2018 milestone Apr 25, 2018
@mjbvz mjbvz added the verified Verification succeeded label Apr 26, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
polish Cleanup and polish issue tree-views Extension tree view issues verified Verification succeeded
Projects
None yet
Milestone
April 2018
Development

No branches or pull requests
3 participants
@sbatten @sandy081 @mjbvz