Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolveRenameLocation - Cannot read property of 'undefined #48592

Closed
mjbvz opened this issue Apr 24, 2018 · 0 comments
Closed

resolveRenameLocation - Cannot read property of 'undefined #48592

mjbvz opened this issue Apr 24, 2018 · 0 comments
Assignees
@jrieken
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
April 2018

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Apr 24, 2018

Testing #48409

Repo steps

  1. For a simple extension using the new resolveRenameLocation api:
import * as vscode from 'vscode';

export function activate(context: vscode.ExtensionContext) {
   vscode.languages.registerRenameProvider('markdown', new class implements vscode.RenameProvider {
       provideRenameEdits(document: vscode.TextDocument, position: vscode.Position, newName: string, token: vscode.CancellationToken): vscode.ProviderResult<vscode.WorkspaceEdit> {
           const range = document.getWordRangeAtPosition(position);
           if (range.isEmpty){
               return undefined;
           }
           const edit = new vscode.WorkspaceEdit();
           edit.replace(document.uri, range, 
               '🐈' + newName);
        return edit;
       }

       resolveRenameLocation?(document: vscode.TextDocument, position: vscode.Position, token: vscode.CancellationToken): vscode.ProviderResult<vscode.Range | { range: vscode.Range, placeholder: string }> {
           return new vscode.Range(0, 0, 0, 10);
       }
   });
}
  1. Try trigger rename in a md file.

Bug
See the error:

Cannot read property 'document' of undefined: TypeError: Cannot read property 'document' of undefined
	at e.resolveRenameLocation (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/node/extensionHostProcess.js:655:42)
	at /Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/node/extensionHostProcess.js:667:453
	at e._withAdapter (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/node/extensionHostProcess.js:661:115)
	at e.$resolveRenameLocation (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/node/extensionHostProcess.js:667:415)
	at e._doInvokeHandler (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/node/extensionHostProcess.js:598:737)
	at e._invokeHandler (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/node/extensionHostProcess.js:598:455)
	at e._receiveRequest (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/node/extensionHostProcess.js:597:529)
	at e._receiveOneMessage (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/node/extensionHostProcess.js:597:298)
	at /Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/node/extensionHostProcess.js:596:226
	at /Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/node/extensionHostProcess.js:599:324
	at /Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/node/extensionHostProcess.js:88:119
	at e.fire (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/node/extensionHostProcess.js:89:496)
	at Socket.<anonymous> (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/workbench/node/extensionHostProcess.js:145:1008)
	at emitOne (events.js:96:13)
	at Socket.emit (events.js:191:7)
	at readableAddChunk (_stream_readable.js:178:18)
	at Socket.Readable.push (_stream_readable.js:136:10)
	at Pipe.onread (net.js:560:20)
@mjbvz mjbvz mentioned this issue Apr 24, 2018
Closed
2 tasks
@mjbvz mjbvz added this to the April 2018 milestone Apr 25, 2018
@mjbvz mjbvz closed this as completed in 1e7095e Apr 25, 2018
@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug verified Verification succeeded labels Apr 26, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
April 2018
Development

No branches or pull requests
2 participants
@jrieken @mjbvz