Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workbench picks up settings.json file at the top of the workspace #48627

Closed
shizengzhou opened this issue Apr 25, 2018 · 16 comments
Closed

Workbench picks up settings.json file at the top of the workspace #48627

shizengzhou opened this issue Apr 25, 2018 · 16 comments
Assignees
@sandy081
Labels
bug Issue identified by VS Code Team member as probable bug config VS Code configuration, set up issues verified Verification succeeded
Milestone
April 2018

Comments

@shizengzhou
Copy link
Contributor

Issue Type: Bug

  1. Open a project
  2. Use Git: Pull command in the Command Palette
    The file icons disappeared and there is an error.
    renderer3.log

VS Code version: Code - Insiders 1.23.0-insider (b845ce9, 2018-04-24T05:17:07.677Z)
OS version: Windows_NT x64 10.0.16299

System Info
Item Value
CPUs Intel(R) Core(TM) i3-6100U CPU @ 2.30GHz (4 x 2304)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: disabled_software
video_decode: enabled
video_encode: enabled
vpx_decode: unavailable_software
webgl: enabled
webgl2: enabled
Memory (System) 7.89GB (3.59GB free)
Process Argv C:\Program Files\Microsoft VS Code Insiders\Code - Insiders.exe
Screen Reader no
VM 0%
Extensions (4)
Extension Author (truncated) Version
vscode-eslint dba 1.4.8
EditorConfig Edi 0.12.1
tslint eg2 1.0.28
debugger-for-chrome msj 4.3.0
@vscodebot vscodebot bot added the insiders label Apr 25, 2018
@vscodebot
Copy link

vscodebot bot commented Apr 25, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@bpasero
Copy link
Member

bpasero commented Apr 25, 2018

@shizengzhou can you share a screenshot how this looks like for you?

@bpasero bpasero added the info-needed Issue requires more information from poster label Apr 25, 2018
@joaomoreno
Copy link
Member

The error in the log is #48523

@shizengzhou Yes, please share a screenshot.

@shizengzhou
Copy link
Contributor Author

explorer
There is a settings.json and the json file's indentation using tab. I change its indentation with space and push the change to the remote repository. On another PC, the issue appears when I use Git: Pull command in the Command Palette to pull.

@shizengzhou shizengzhou changed the title After git pull, the file icons disappeared and there is an error After git pull, the file icons disappeared Apr 25, 2018
@joaomoreno
Copy link
Member

@bpasero Have you seen this before? I don't think this is related to git at all.

@bpasero
Copy link
Member

bpasero commented Apr 25, 2018

@joaomoreno no this is news to me

/cc @aeschli @sandy081

@shizengzhou can you make sure to reproduce with todays latest insider?

@shizengzhou
Copy link
Contributor Author

@bpasero I'm sure to reproduce with todays latest insider.

@bpasero
Copy link
Member

bpasero commented Apr 25, 2018

@shizengzhou are the icons coming back when you change the icon theme?

@shizengzhou
Copy link
Contributor Author

@bpasero VS Code seems to treat the settings.json in the project as my settings.json by mistake.

@sandy081
Copy link
Member

@shizengzhou You mean settings.json under .vscode folder? And does it has file icon theme setting?

@shizengzhou
Copy link
Contributor Author

@sandy081 There is no .vscode folder. Yes, it has file icon theme setting.

@sandy081
Copy link
Member

Yes, file icon theme in the workspace settings is overriding your theme in user settings which is expected.

@joaomoreno
Copy link
Member

@sandy081 But the file is at the root of the workspace, not in .vscode/settings.json.

@joaomoreno joaomoreno assigned sandy081 and unassigned joaomoreno Apr 25, 2018
@joaomoreno joaomoreno changed the title After git pull, the file icons disappeared Workbench picks up settings.json file at the top of the workspace Apr 25, 2018
@joaomoreno
Copy link
Member

@sandy081 I just hit this too by accident, seems like a regression.

@joaomoreno
Copy link
Member

joaomoreno commented Apr 25, 2018 •
edited

Also, when that happens, changing a theme causes a .vscode/settings.json file to be created with that theme selection. 😮

@sandy081 sandy081 added bug Issue identified by VS Code Team member as probable bug config VS Code configuration, set up issues and removed info-needed Issue requires more information from poster labels Apr 26, 2018
@sandy081 sandy081 added this to the April 2018 milestone Apr 26, 2018
@sandy081
Copy link
Member

Yeah.. it is a regression from my refactorings. My relative checks were happening on root folder instead of .vscode folder and caused this.

@shizengzhou Thanks for reporting this.

@roblourens roblourens added the verified Verification succeeded label Apr 27, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
bug Issue identified by VS Code Team member as probable bug config VS Code configuration, set up issues verified Verification succeeded
Projects
None yet
Milestone
April 2018
Development

No branches or pull requests
5 participants
@joaomoreno @roblourens @bpasero @sandy081 @shizengzhou