Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileSystemProvider: unable to save with or reopen with encoding #48662

Closed
bpasero opened this issue Apr 25, 2018 · 4 comments
Closed

FileSystemProvider: unable to save with or reopen with encoding #48662

bpasero opened this issue Apr 25, 2018 · 4 comments
Assignees
@jrieken
Labels
bug Issue identified by VS Code Team member as probable bug remote Remote system operations issues verified Verification succeeded
Milestone
April 2018

Comments

@bpasero
Copy link
Member

bpasero commented Apr 25, 2018

Refs: #48421

Setup:

  • clone https://github.com/bpasero/remote-fs
  • F5
  • click "Refresh" in the explorer
  • you should see the current working directory as a remote folder using the file system provider for scheme datei://

Steps

  • open a file
  • click in the status bar on the encoding picker to either reopen or save with encoding

=> we do not seem to support this, nothing happens

/cc @jrieken
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug remote Remote system operations issues labels Apr 25, 2018
@bpasero bpasero self-assigned this Apr 25, 2018
@jrieken
Copy link
Member

jrieken commented Apr 25, 2018 


encoding.js:123 Uncaught (in promise) TypeError: Cannot read property 'end' of undefined
    at encoding.js:123
    at encoding.js:112
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:109)

@jrieken jrieken added this to the April 2018 milestone Apr 25, 2018
@bpasero
Copy link
Member Author

bpasero commented Apr 25, 2018 •
edited

@jrieken yes I was about to report, seems to originate from the toDecodeStream

@bpasero bpasero assigned jrieken and unassigned bpasero Apr 25, 2018
@jrieken
Copy link
Member

jrieken commented Apr 25, 2018

This is some bizarre WinJS.Promise vs Promise thing

jrieken added a commit that referenced this issue Apr 25, 2018
@jrieken
unsure what's happening here... #48662
e572ffc
@jrieken jrieken closed this as completed Apr 25, 2018
@bpasero bpasero added the verified Verification succeeded label Apr 27, 2018
@jrieken
Copy link
Member

jrieken commented Apr 27, 2018 •
edited

I do have a better understand of this and it's scary... During Promise.resolve (which is async) the winjs-promise resolves and goes into the success-state which is a oneway, e.g. it doesn't have a then-function. Somehow, tho Promise.resolve still holds on to that and ends up calling it and boom. The take aways is to not use a winjs-promise in Promise.resolve.

@bpasero bpasero mentioned this issue May 4, 2018
Closed
jrieken added a commit that referenced this issue Jun 1, 2018
@jrieken
better logging for #48662
5d631c2
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
bug Issue identified by VS Code Team member as probable bug remote Remote system operations issues verified Verification succeeded
Projects
None yet
Milestone
April 2018
Development

No branches or pull requests
2 participants
@bpasero @jrieken