Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RunInTerminalResponse given from vscode does not have a body. #48680

Closed
fabioz opened this issue Apr 25, 2018 · 3 comments
Closed

RunInTerminalResponse given from vscode does not have a body. #48680

fabioz opened this issue Apr 25, 2018 · 3 comments
Assignees
@weinand
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone
April 2018

Comments

@fabioz
Copy link
Contributor

fabioz commented Apr 25, 2018 •
edited

  • VSCode Version: 1.22.2
  • OS Version: Windows 10

The debug protocol:
https://raw.githubusercontent.com/Microsoft/vscode-debugadapter-node/master/debugProtocol.json specifies that RunInTerminalResponse has a mandatory body, yet, the result from vscode when asked to run something in the integrated terminal does not have a body.

i.e.: The output I have is {'request_seq': 2, 'command': 'runInTerminal', 'type': 'response', 'success': True, 'seq': 5}

So, even if the body is an empty object, the actual body should be there (or the specification should be updated to make it optional).
@weinand
Copy link
Contributor

weinand commented Apr 25, 2018

Since making a mandatory element optional would be a breaking DAP change, I've made sure that VS Code returns a 'body' element in the response.

@weinand weinand added this to the April 2018 milestone Apr 25, 2018
@weinand weinand added debug Debug viewlet, configurations, breakpoints, adapter issues bug Issue identified by VS Code Team member as probable bug labels Apr 25, 2018
@fabioz
Copy link
Contributor Author

fabioz commented Apr 25, 2018

Thanks for the quick turnaround 😄

@weinand
Copy link
Contributor

weinand commented Apr 25, 2018

Yeah, that was a simple, low-risk fix... ;-)

@roblourens roblourens added the verified Verification succeeded label Apr 27, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@weinand weinand

Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Milestone
April 2018
Development

No branches or pull requests
3 participants
@fabioz @roblourens @weinand