Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

showInputBox does not focus back to editor after dismiss #48847

Closed
rebornix opened this issue Apr 27, 2018 · 0 comments
Closed

showInputBox does not focus back to editor after dismiss #48847

rebornix opened this issue Apr 27, 2018 · 0 comments
Assignees
@chrmarti
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release quick-pick Quick-pick widget issues verified Verification succeeded
Milestone
April 2018

Comments

@rebornix
Copy link
Member

  • VSCode Version: 1.23 Insiders
  • OS Version: macOS

Steps to Reproduce:

  1. Write an extension
'use strict';
import * as vscode from 'vscode';

export function activate(context: vscode.ExtensionContext) {
	vscode.commands.registerCommand('hello', () => {
		vscode.window.showInputBox({});
	})
}
  1. Launch
  2. Run command hello from command palette.
  3. Press Esc to dismiss
  4. In Stable, the editor gets focus again. While in Insider, the editor does not.
@vscodebot vscodebot bot added the insiders label Apr 27, 2018
@rebornix rebornix added this to the April 2018 milestone Apr 27, 2018
@rebornix rebornix mentioned this issue Apr 27, 2018
Closed
@chrmarti chrmarti removed this from the April 2018 milestone Apr 30, 2018
@chrmarti chrmarti added the candidate Issue identified as probable candidate for fixing in the next release label Apr 30, 2018
chrmarti added a commit that referenced this issue Apr 30, 2018
@chrmarti
Pass focus to editor when closing (#48847)
fdd6df3
chrmarti added a commit that referenced this issue Apr 30, 2018
@chrmarti
Pass focus to editor when closing (#48847)
c1c09f0
@chrmarti chrmarti added this to the April 2018 milestone Apr 30, 2018
@chrmarti chrmarti added bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues labels Apr 30, 2018
@rebornix rebornix added the verified Verification succeeded label May 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chrmarti chrmarti

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release quick-pick Quick-pick widget issues verified Verification succeeded
Projects
None yet
Milestone
April 2018
Development

No branches or pull requests
2 participants
@rebornix @chrmarti