Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Marketplace German Language Pack prompt installing Insiders version #49126

Closed
gregvanl opened this issue May 3, 2018 · 0 comments
Closed

Marketplace German Language Pack prompt installing Insiders version #49126

gregvanl opened this issue May 3, 2018 · 0 comments
Assignees
@chrmarti
Labels
bug Issue identified by VS Code Team member as probable bug l10n-platform Localization platform issues (not wrong translations) verified Verification succeeded
Milestone
April 2018

Comments

@gregvanl
Copy link

gregvanl commented May 3, 2018

  • VSCode Version: 1.23.0 Stable
  • OS Version: Windows

Steps to Reproduce:

  1. Set the locale to "de" and restart VS Code 1.23 Stable
  2. When the prompt shows up to install the Marketplace German Language Pack, it is mentioning the Insiders version.

image

  1. If you choose to install the Language Pack, it does install the Insiders version. MS-CEINTL.vscode-insiders-language

image

Should this be installing the stable version, MS-CEINTL.vscode-language-pack-de?
@vscodebot vscodebot bot added the extensions Issues concerning extensions label May 3, 2018
@chrmarti chrmarti self-assigned this May 3, 2018
@chrmarti chrmarti added bug Issue identified by VS Code Team member as probable bug l10n-platform Localization platform issues (not wrong translations) and removed extensions Issues concerning extensions labels May 3, 2018
@chrmarti chrmarti added this to the April 2018 milestone May 3, 2018
chrmarti added a commit that referenced this issue May 3, 2018
@chrmarti
Fix logic for choosing insider/stable language pack (fixes #49126)
7c7da59
@gregvanl gregvanl added the verified Verification succeeded label May 3, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chrmarti chrmarti

Labels
bug Issue identified by VS Code Team member as probable bug l10n-platform Localization platform issues (not wrong translations) verified Verification succeeded
Projects
None yet
Milestone
April 2018
Development

No branches or pull requests
2 participants
@chrmarti @gregvanl