Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

File with weird name in extension package causes extension install to fail on Windows #49289

Closed
roblourens opened this issue May 6, 2018 · 6 comments
Closed

File with weird name in extension package causes extension install to fail on Windows #49289

roblourens opened this issue May 6, 2018 · 6 comments
Assignees
@sandy081
Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions verified Verification succeeded windows VS Code on Windows issues
Milestone
September 2018

Comments

@roblourens
Copy link
Member

Chrome-debug version 4.4.0 was published with files named (*&)))&^.js and (*&)))&^.d.ts. These apparently caused the unzip to fail, so the extension showed "installing" forever - just on Windows. We should figure out whether there's a way to recover from that.
@roblourens roblourens mentioned this issue May 6, 2018
Closed
@sandy081
Copy link
Member

sandy081 commented May 7, 2018 •
edited

@roblourens At what step is the installation failing? If unzip is failing and an error is thrown, installation should be stopped and the error is shown.

@sandy081 sandy081 added extensions Issues concerning extensions info-needed Issue requires more information from poster labels May 7, 2018
@roblourens
Copy link
Member Author

Extension is here if you want to try it: https://marketplace.visualstudio.com/_apis/public/gallery/publishers/msjsdiag/vsextensions/debugger-for-chrome/4.4.0/vspackage

It looks like an error wouldn't be handled here: https://github.com/Microsoft/vscode/blob/84d023798b51a8ad607fd865dd8e16949ee3c398/src/vs/base/node/zip.ts#L137

@vscodebot vscodebot bot closed this as completed May 16, 2018
@vscodebot
Copy link

vscodebot bot commented May 16, 2018

This issue has been closed automatically because it needs more information and has not had recent activity. See also our issue reporting guidelines.

Happy Coding!

@roblourens roblourens reopened this May 16, 2018
@sandy081 sandy081 removed the info-needed Issue requires more information from poster label May 16, 2018
@sandy081 sandy081 added this to the May 2018 milestone May 16, 2018
@sandy081
Copy link
Member

sandy081 commented May 30, 2018 •
edited

Sorry did not get time to look into this. Will try to reproduce in my Windows VM in.

Edit: @roblourens Let me know if it is a blocker and you have workaround for this?

@sandy081 sandy081 modified the milestones: May 2018, June 2018 May 30, 2018
@roblourens
Copy link
Member Author

Not blocking me

@sandy081 sandy081 modified the milestones: May 2018, June 2018 May 31, 2018
@sandy081 sandy081 modified the milestones: June 2018, July 2018 Jun 27, 2018
@roblourens roblourens removed their assignment Jul 2, 2018
@sandy081 sandy081 added the bug Issue identified by VS Code Team member as probable bug label Jul 9, 2018
@sandy081 sandy081 modified the milestones: July 2018, September 2018 Jul 26, 2018
sandy081 added a commit that referenced this issue Sep 19, 2018
@sandy081
#49289 Fix Error handling
a24e1ba
@sandy081 sandy081 added the windows VS Code on Windows issues label Sep 19, 2018
@sandy081
Copy link
Member

Fixed. It throws error now instead of getting stuck.

@sbatten sbatten added the verified Verification succeeded label Sep 27, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@sandy081 sandy081

Labels
bug Issue identified by VS Code Team member as probable bug extensions Issues concerning extensions verified Verification succeeded windows VS Code on Windows issues
Projects
None yet
Milestone
September 2018
Development

No branches or pull requests
3 participants
@roblourens @sbatten @sandy081