-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verified false breakpoint w/message does not reflect message in breakpoint list UI #4935
Comments
@rkeithhill and where would you show that message in the breakpoints view without introducing too much clutter? I suggest to show it on hover. What do you think? |
@isidorn Yeah but I was also thinking that the Breakpoints viewlet could show a glyph indicating there is a problem with the breakpoint and then provide a tooltip (hover as you put it) to display the message e.g.: But if you don't like the extra glyph - maybe the checkbox is shown in an indeterminate state? Or perhaps the breakpoint text is red or perhaps the text uses strike-through. You just need some sort of indication to draw their attention and then the hover would explain why the breakpoint wasn't set. |
Now if the breakpoint is unverified we show the message on hover and we show the whole breakpoint grayed out - same as how we show all breakpoints when you deactivate them. |
@isidorn I'm not able to verify this fix in the latest alpha. With the breakpoint set in the now nonexistent original DebugTest.ps1 I am also not able to debug other files. |
@vsccarl the issue with not being able to debug with the PowerShell is a known issue with the PowerShell extension. We should have a fixed version (0.6.0) released in a week or so. For now, you can work around this by setting a breakpoint in your program and then you should be able to debug. That said I'm not seeing this issue as fixed on my machine at work with today's alpha build. I will need to check later tonight on my home dev machine with daily 0.6.0 PS extension bits. |
@isidorn OK, checked the PSES ext daily bits and I still don't see the breakpoint grayed out and there is no hover tip. Now I am checking this in the BREAKPOINTS viewlet which I assume is what you're talking about, right? Because the breakpoints in question are for files that no longer exist so it would be impossible to see the grayed out breakpoint in the editor window. :-) |
@rkeithhill yeah, it is in the breakpoints veiwlet :) Today is last game of endgame, which means we only look at critical bugs, thus I will investigate why is this not fixed on monday, though that means it will only be available in our may release. |
Yes we set verified to false. Is there anything else in this response message that might be wrong? Log file snippet from debug session:
|
Found the issue - now it should work |
@isidorn I've confirmed the fix. Thanks! |
Steps to Reproduce:
I would have expected at least the tooltip to display the message that we return from the debug host e.g.:
I get that the message is normally meant for the tooltip on the breakpoint glyph in the editor gutter but if the user doesn't happen to have that file open (or it does not exist anymore), they won't see the error.
I think the breakpoints list in the Debug should "reflect" breakpoints that failed verification and provide the user with a way to see the message returned by the debug host.
PowerShell/PowerShellEditorServices#195
The text was updated successfully, but these errors were encountered: