Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When the name in the VariablesResponse is a 0-length string, this variable cannot be seen in the vscode GUI. #49355

Closed
actboy168 opened this issue May 7, 2018 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone

Comments

@actboy168
Copy link

Issue Type: Bug

Watch panel, variables panel and debug console can reproduce this problem.

VS Code version: Code 1.23.0 (7c7da59, 2018-05-03T16:44:10.813Z)
OS version: Windows_NT ia32 10.0.16299

@vscodebot vscodebot bot added the new release label May 7, 2018
@isidorn isidorn self-assigned this May 7, 2018
@isidorn isidorn added debug Debug viewlet, configurations, breakpoints, adapter issues and removed new release labels May 7, 2018
@isidorn
Copy link
Contributor

isidorn commented May 7, 2018

Yes this is correct, currently we use the name to compute the Variable id here
Thus we filter out any varialbe without a name here

In theory we could support one variable without a name per parent however I am reluctant to make that change.

What is the actual use case of this? Since none of the users complained about this.

fyi @weinand

@isidorn isidorn added the under-discussion Issue is under discussion for relevance, priority, approach label May 7, 2018
@actboy168
Copy link
Author

I'm sending a 0-length string, not null, so it's not without a name. I think 0-length strings are the same as other strings.

@weinand
Copy link
Contributor

weinand commented May 7, 2018

@isidorn if chrome dev tools support this, we should too (even if it doesn‘t make a lot of sense).
If I remember correctly we even support variable names that start with spaces and we quote those names so that the spaces become visible.

@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug and removed under-discussion Issue is under discussion for relevance, priority, approach labels May 8, 2018
@isidorn
Copy link
Contributor

isidorn commented May 8, 2018

Thanks for the feedback.
Chrome dev tools also support this.

I have pushed a fix for this.
@actboy168 it would be great if you could try this out tomorrow and let us know if the issue is fixed for you

@isidorn isidorn added this to the May 2018 milestone May 8, 2018
@isidorn isidorn closed this as completed in 43646f8 May 8, 2018
@actboy168
Copy link
Author

I try today's vscode, 0 length string variable can already be seen. But it missing a colon.
2

The first line is a variable of 0 length string, the second line is a variable of 1 space, and the third line is a normal variable.

@isidorn
Copy link
Contributor

isidorn commented May 9, 2018

@actboy168 thanks for the quick response I have fixed this issue with c986442 and should be in tomorrow's insiders.

isidorn added a commit that referenced this issue May 9, 2018
@weinand weinand added the verified Verification succeeded label May 31, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants