Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Terminal API: Shared terminal won't send data for subsequent task executions #49379

Closed
alpaix opened this issue May 7, 2018 · 4 comments
Closed

Terminal API: Shared terminal won't send data for subsequent task executions #49379

alpaix opened this issue May 7, 2018 · 4 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug tasks Task system issues terminal Integrated terminal issues verified Verification succeeded
Milestone
May 2018

Comments

@alpaix
Copy link

alpaix commented May 7, 2018 •
edited

Version 1.23.0
Commit 7c7da59
Date 2018-05-03T16:44:10.813Z
Shell 1.7.12
Renderer 58.0.3029.110
Node 7.9.0
Architecture ia32

Steps to Reproduce

  1. Add a task to a project with "presentation.panel": "shared"
{
    "version": "2.0.0",
    "tasks": [
        {
            "type": "npm",
            "script": "start",
            "problemMatcher": [
                "$eslint-compact"
            ],
            "presentation": {
                "echo": true,
                "reveal": "always",
                "focus": false,
                "panel": "shared"
            },
            "isBackground": true
        }
    ]
}
  1. Run the task in a task terminal with a listener attached to onData.
  2. Observe data being sent to the listener.
  3. Run the task again.

Expected

The listener receives data sent to the terminal.

Actual

No data sent.
@vscodebot vscodebot bot added the tasks Task system issues label May 7, 2018
@dbaeumer dbaeumer added terminal Integrated terminal issues and removed tasks Task system issues labels May 8, 2018
@dbaeumer dbaeumer assigned Tyriar and unassigned dbaeumer May 8, 2018
@dbaeumer
Copy link
Member

dbaeumer commented May 8, 2018

@Tyriar assigning to you since the onData is on the terminal in the extension API. Please ping if I need to do something special in the shared use case.

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug tasks Task system issues labels May 14, 2018
@Tyriar Tyriar added this to the May 2018 milestone May 14, 2018
@alpaix
Copy link
Author

alpaix commented May 16, 2018

@Tyriar Did you have a chance to take a look into it? This bug is blocking our e2e scenario 😞

@Tyriar
Copy link
Member

Tyriar commented May 16, 2018

I've assigned it to May so I'll try get to it, I'm a bit overwhelmed this iteration so I hope it will get done but it may slip.

@Tyriar Tyriar closed this as completed in 4370759 May 25, 2018
@aeschli aeschli added the verified Verification succeeded label Jun 1, 2018
@aeschli
Copy link
Contributor

aeschli commented Jun 1, 2018

Verified that the second invocation of the task still results in onData callback.

@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug tasks Task system issues terminal Integrated terminal issues verified Verification succeeded
Projects
None yet
Milestone
May 2018
Development

No branches or pull requests
4 participants
@dbaeumer @Tyriar @aeschli @alpaix