Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visual Studio Code should honor a editor.fontSize value smaller than 8 #49428

Closed
webermatthew opened this issue May 8, 2018 · 3 comments
Closed

Visual Studio Code should honor a editor.fontSize value smaller than 8 #49428

webermatthew opened this issue May 8, 2018 · 3 comments
Assignees
@alexdima
Labels
editor-rendering Editor rendering issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone
October 2019

Comments

@webermatthew
Copy link

webermatthew commented May 8, 2018 •
edited

No matter how small you set "editor.fontSize" in visual studio code, it doesn't actually render any smaller than the "8" size. Go ahead, try "5" or "6" - it will just display the "8" size.

I'd really like to push my retina screen to the max and be able to pick smaller fontSizes – with a good pair of magnifying reading glasses or loupes, you can easily read smaller sizes. Super-small font sizes are incredibly helpful when working with a split editor on a laptop.
@webermatthew webermatthew changed the title Visual Studio Code should honor a fontSize value smaller than 8 Visual Studio Code should honor a editor.fontSize value smaller than 8 May 8, 2018
@alexdima alexdima added feature-request Request for new features or functionality editor-rendering Editor rendering issues labels Jul 27, 2018
@alexdima
Copy link
Member

Would you consider contributing a PR? I suggest to not go lower than 5 or 6, as folks have accidentally set a very small fontSize in the settings and were then blocked.

https://github.com/Microsoft/vscode/blob/b2c8d97d9b8817ded0eaf8419ee24905889a9edc/src/vs/editor/common/config/fontInfo.ts#L20

@alexdima alexdima added this to the Backlog milestone Jul 27, 2018
@alexdima alexdima removed their assignment Jul 27, 2018
@alexdima alexdima modified the milestones: Backlog, October 2019 Oct 23, 2019
@alexdima alexdima self-assigned this Oct 23, 2019
@alexdima alexdima added the verification-needed Verification of issue is requested label Oct 28, 2019
@alexr00
Copy link
Member

alexr00 commented Oct 29, 2019 •
edited

Works nicely! It might be nice to have a minimum in the setting, similar to task.quickOpen.history so that it is very clear that numbers smaller than 6 don't do anything.

@alexr00 alexr00 added the verified Verification succeeded label Oct 29, 2019
alexdima added a commit that referenced this issue Oct 29, 2019
@alexdima
Add minimum and maximum to schema for fontSize (#49428)
e30276a
@alexdima
Copy link
Member

Nice suggestion! Done!

@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
editor-rendering Editor rendering issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
October 2019
Development

No branches or pull requests
3 participants
@webermatthew @alexdima @alexr00