-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider renaming column breakpoints to "inline breakpoints" #49503
Comments
Ha! you beat me to it :) I don't think it's just the chrome dev tools term that drives this. I'm not sure "column" is intuitive. But let's ask the users here to see what they think |
Inline breakpoints is a lot clearer. Using the same name as the chrome tools for the same concept is a welcome bonus. |
Inline breakpoint is pretty good, but maybe callback breakpoint is a good alternative. Depends on how it works. Is this specifically meant for debugging async calls or also for debugging one of many statements in a single line of code? |
Thanks for the feedback. Let's wait and try to get @weinand @roblourens feedback. |
I'd go with Inline Breakpoint. Inline Breakpoint has a broader sense in comparison to Column Breakpoint. Also, it stays pretty agnostic in comparison to callback breakpoint, which could have sense only in the js world assuming this functionality will be used also with other languages. |
Async point? Async debug? |
@urbanit "Column breakpoints" are independent from any language (feature). You can set a column breakpoint even in Fortran 77 (but I doubt that they support an "async" language construct yet...) We use the term "column" because the editor refers to the character positions within a line as "Columns": |
I see your point @weinand . Despite the fact that editor refers to Col, term "Column" is kind of unfamiliar to, at least to me. But, you are right about the need of lang neutrality. I will go with Inline then. ;-) |
aka inline |
Inline is fine with me. Maybe "column breakpoints" is more of an implementation-focused term. |
I have no strong feelings about this, so "Inline Breakpoint" is fine by me. |
@weinand sure, I will change it everywhere in the UI and mention it in the release notes. |
@isidorn I suggest to introduce a new command id with an appropriate name but keep the old id forever for backward compatability (like ‚workspaceRoot‘). Ideally the old name should not show up in the keyboard shortcuts UI. |
thank you for exploring this |
Consider renaming column breakpoints to "inline breakpoints"
Rationale: Use similar wording that Chrome DevTools are using
Feedback from John Papa, CDA:
"ive never heard column breakpoints. and every time we talk about the feature we hear that it's confusing. , but from what I hear from folks, inline is what they expect"
"i am giving it to you. over 1500 people i've presented this to in the past month. I haven't had anyone say "column breakpoints make sense" yet I have had a ton of folks say they think inline makes more sense (when I ask them what is clearer)."
Chrome DevTools demo:
https://umaar.com/dev-tips/129-inline-breakpoints/
The text was updated successfully, but these errors were encountered: