Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider renaming column breakpoints to "inline breakpoints" #49503

Closed
auchenberg opened this issue May 9, 2018 · 14 comments
Closed

Consider renaming column breakpoints to "inline breakpoints" #49503

auchenberg opened this issue May 9, 2018 · 14 comments
Assignees
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality release-notes Release notes issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@auchenberg
Copy link
Contributor

Consider renaming column breakpoints to "inline breakpoints"

Rationale: Use similar wording that Chrome DevTools are using

Feedback from John Papa, CDA:

"ive never heard column breakpoints. and every time we talk about the feature we hear that it's confusing. , but from what I hear from folks, inline is what they expect"

"i am giving it to you. over 1500 people i've presented this to in the past month. I haven't had anyone say "column breakpoints make sense" yet I have had a ton of folks say they think inline makes more sense (when I ask them what is clearer)."

Chrome DevTools demo:
https://umaar.com/dev-tips/129-inline-breakpoints/

@johnpapa
Copy link

johnpapa commented May 9, 2018

Ha! you beat me to it :)

I don't think it's just the chrome dev tools term that drives this. I'm not sure "column" is intuitive.

But let's ask the users here to see what they think

@TekSiDoT
Copy link

TekSiDoT commented May 9, 2018

Inline breakpoints is a lot clearer. Using the same name as the chrome tools for the same concept is a welcome bonus.

@casvaniersel
Copy link

Inline breakpoint is pretty good, but maybe callback breakpoint is a good alternative. Depends on how it works. Is this specifically meant for debugging async calls or also for debugging one of many statements in a single line of code?

@isidorn
Copy link
Contributor

isidorn commented May 9, 2018

Thanks for the feedback.
If inline breakpoints is what the users expect we can change the name - it works for me.

Let's wait and try to get @weinand @roblourens feedback.

@isidorn isidorn added this to the May 2018 milestone May 9, 2018
@isidorn isidorn added the debug Debug viewlet, configurations, breakpoints, adapter issues label May 9, 2018
@NKjoep
Copy link

NKjoep commented May 9, 2018

I'd go with Inline Breakpoint.

Inline Breakpoint has a broader sense in comparison to Column Breakpoint.

Also, it stays pretty agnostic in comparison to callback breakpoint, which could have sense only in the js world assuming this functionality will be used also with other languages.

@urbanit
Copy link

urbanit commented May 9, 2018

Async point? Async debug?

@weinand
Copy link
Contributor

weinand commented May 9, 2018

@urbanit "Column breakpoints" are independent from any language (feature). You can set a column breakpoint even in Fortran 77 (but I doubt that they support an "async" language construct yet...)

We use the term "column" because the editor refers to the character positions within a line as "Columns":
2018-05-09_15-29-50

@urbanit
Copy link

urbanit commented May 9, 2018

I see your point @weinand . Despite the fact that editor refers to Col, term "Column" is kind of unfamiliar to, at least to me. But, you are right about the need of lang neutrality. I will go with Inline then. ;-)

@shannonmoeller
Copy link

positions within a line

aka inline

@roblourens
Copy link
Member

roblourens commented May 9, 2018

Inline is fine with me. Maybe "column breakpoints" is more of an implementation-focused term.

@weinand
Copy link
Contributor

weinand commented May 9, 2018

I have no strong feelings about this, so "Inline Breakpoint" is fine by me.
But changing the name of a feature needs appropriate communication.
@isidorn please plan and execute accordingly.

@isidorn
Copy link
Contributor

isidorn commented May 10, 2018

@weinand sure, I will change it everywhere in the UI and mention it in the release notes.
The only command id which has column breakpoint in it will stay the same editor.debug.action.toggleColumnBreakpoint to not break existing behavior. This is fine since it is not user facing most of the time.
Thanks

@weinand
Copy link
Contributor

weinand commented May 10, 2018

@isidorn I suggest to introduce a new command id with an appropriate name but keep the old id forever for backward compatability (like ‚workspaceRoot‘). Ideally the old name should not show up in the keyboard shortcuts UI.
Keeping only the old id is confusing and not really discoverable.

@weinand weinand added the feature-request Request for new features or functionality label May 10, 2018
@isidorn isidorn added the verification-needed Verification of issue is requested label May 10, 2018
@johnpapa
Copy link

thank you for exploring this

@roblourens roblourens added the verified Verification succeeded label May 30, 2018
@isidorn isidorn added the release-notes Release notes issues label Jun 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jun 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
debug Debug viewlet, configurations, breakpoints, adapter issues feature-request Request for new features or functionality release-notes Release notes issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

10 participants