Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[pug] Use pug grammar #50086

Closed
lunelson opened this issue May 18, 2018 · 5 comments
Closed

[pug] Use pug grammar #50086

lunelson opened this issue May 18, 2018 · 5 comments
Assignees
@aeschli
Labels
languages-basic Basic language support issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
May 2018

Comments

@lunelson
Copy link

Vscode's pug language definition currently relies on an outdated external source. It uses a conversion script which pulls from the Sublime Text plugin https://github.com/davidrios/jade-tmbundle/, rather than the current version of that code, which is https://github.com/davidrios/pug-tmbundle/.

There may not be much difference 🤷‍♂️. However in principle I think the source should be updated. Moreover, that repo has a pending PR from me concerning filter block syntax support in pug, which I would like to see in vscode some day 😏.

If this is as simple as it looks, I'd be glad to do a PR for it. Maybe a maintainer can just confirm the viability?
@aeschli aeschli changed the title Update Pug language definition conversion-source [pug] Use pug grammar & rename language id May 22, 2018
@aeschli aeschli added languages-basic Basic language support issues verification-needed Verification of issue is requested labels May 22, 2018
@aeschli aeschli added this to the May 2018 milestone May 22, 2018
@aeschli
Copy link
Contributor

aeschli commented May 22, 2018

Thanks for filing the issue and for offering help. There are some more steps necessary: updating dependencies and getting the legal work done, so let me do that.

@aeschli
Copy link
Contributor

aeschli commented May 22, 2018

To verify:

  • test that jade and pug files still have syntax highlighting
  • test pug embedded in markdown

This was referenced May 22, 2018
Merged
Closed
@aeschli aeschli changed the title [pug] Use pug grammar & rename language id [pug] Use pug grammar May 29, 2018
@aeschli
Copy link
Contributor

aeschli commented May 29, 2018

Note: I reverted the rename of the language id as this would break many extensions.
But verification remains the same.

@roblourens roblourens added the verified Verification succeeded label May 30, 2018
@roblourens
Copy link
Member

roblourens commented May 30, 2018 •
edited

Still need the markdown grammar change? ```jade or ```pug should trigger it, right?

@aeschli
Copy link
Contributor

aeschli commented May 31, 2018

@roblourens the scope name has changed to source.pug and the markdown grammar references it. I made the changes in the vscode repo, but the changes should also be made in the markdown grammar repo as to not overwrite the changes on the next update: See microsoft/vscode-markdown-tm-grammar#17

@octref octref mentioned this issue Jun 6, 2018
Closed
3 tasks
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
languages-basic Basic language support issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
May 2018
Development

No branches or pull requests
3 participants
@roblourens @lunelson @aeschli