Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot read property 'setVisible' of undefined #50117

Closed
roblourens opened this issue May 18, 2018 · 8 comments
Closed

Cannot read property 'setVisible' of undefined #50117

roblourens opened this issue May 18, 2018 · 8 comments
Assignees
@joaomoreno @sandy081
Labels
candidate Issue identified as probable candidate for fixing in the next release scm General SCM compound issues verified Verification succeeded
Milestone
May 2018

Comments

@roblourens
Copy link
Member

roblourens commented May 18, 2018 •
edited by sandy081

Steps to Reproduce:

  • Install Gitlens extension
  • Open SCM View and make sure Gitlens view is shown
  • Hide Gitlens view by right clicking and hide
  • Click on Explorer

Expected: No Errors and explorer should be shown
Actual: Errors are shown and explorer is empty

I've seen this constantly when I switch viewlets, since Thursday's Insiders. I can't repro when running out of sources but I think it's related to an extension treeview.

image

Also lots of weird glitches in the sidebar:

image

Stack:

t.setVisible (scmViewlet.ts:1207)
(anonymous) (compositePart.ts:301)
then (winjs.base.js:1581)
t.showComposite (compositePart.ts:247)
(anonymous) (compositePart.ts:152)
then (winjs.base.js:1581)
t.doOpenComposite (compositePart.ts:128)
t.openComposite (compositePart.ts:111)
(anonymous) (sidebarPart.ts:122)
then (winjs.base.js:1581)
t.openViewlet (sidebarPart.ts:122)
e.openViewlet (viewletService.ts:74)
t.run (viewlet.ts:135)
(anonymous) (actions.ts:114)
@vscodebot vscodebot bot added the typescript Typescript support issues label May 18, 2018
@roblourens roblourens removed the typescript Typescript support issues label May 18, 2018
@sbatten
Copy link
Member

sbatten commented May 18, 2018

i'm also experiencing this issue and @roblourens suspects a relation to GitLens which I do have installed. I'm seeing the scm-viewlet in the DOM on top of the explorer-viewlet at the same time.

@BrianArditoAGL
Copy link

I'm seeing this with CTRL+B to toggle Explorer.

@eamodio
Copy link
Contributor

eamodio commented May 21, 2018

GitLens users are seeing this too (I can't seem to reproduce it though): gitkraken/vscode-gitlens#378

This comment seems to provide the culprit:
gitkraken/vscode-gitlens#378 (comment)

Which lines up with this code -- somehow a panel is undefined?
https://github.com/Microsoft/vscode/blob/master/src/vs/workbench/parts/scm/electron-browser/scmViewlet.ts#L1205-L1208

/cc @roblourens @joaomoreno

@eamodio eamodio mentioned this issue May 21, 2018
Closed
@eamodio
Copy link
Contributor

eamodio commented May 21, 2018

FYI, people are reporting it on stable as well as insiders.

@sanket-bhalerao
Copy link

Here is something weird I found for replicating the issue

  • enable GitLens (for me its GitLens, it may or may not be the same for you.)
  • switch to the Source control tab
  • switch back to Explorer tab
  • at first you will see an empty explorer, click on the explorer icon again to see all your files.
  • after this if you click one time on any icon from the left sidebar some weird behavior is seen on the UI
  • the 'setVisible' issue will be visible in the developer tool is visible in the console.

i am on latest release for both VSC insiders and GitLens
VSC -
Version 1.24.0-insider
Commit a521c01
Date 2018-05-21T05:18:01.058Z
Shell 1.7.12
Renderer 58.0.3029.110
Node 7.9.0
Architecture x64

GitLens- 8.3.2

@sandy081 sandy081 added the scm General SCM compound issues label May 22, 2018
@sandy081 sandy081 self-assigned this May 22, 2018
@sandy081 sandy081 added this to the May 2018 milestone May 22, 2018
@sandy081
Copy link
Member

Thanks for the steps. I could reproduce it and update the description with steps.

@sandy081 sandy081 added the candidate Issue identified as probable candidate for fixing in the next release label May 22, 2018
@sandy081
Copy link
Member

Workaround is to enable gitlens view and not disable it at all.

image

@joaomoreno
Copy link
Member

Thanks @sandy081!

@roblourens roblourens added the verified Verification succeeded label May 31, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

@sandy081 sandy081

Labels
candidate Issue identified as probable candidate for fixing in the next release scm General SCM compound issues verified Verification succeeded
Projects
None yet
Milestone
May 2018
Development

No branches or pull requests
8 participants
@joaomoreno @roblourens @eamodio @sbatten @sanket-bhalerao @sandy081 @mjbvz @BrianArditoAGL