Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Progress notifications don't always increment properly #50190

Closed
LaurentTreguier opened this issue May 20, 2018 · 2 comments
Closed

Progress notifications don't always increment properly #50190

LaurentTreguier opened this issue May 20, 2018 · 2 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities verified Verification succeeded workbench-notifications Notification widget issues
Milestone
May 2018

Comments

@LaurentTreguier
Copy link

  • VSCode Version: 1.23.1
  • OS Version: Windows 10 x64

Steps to Reproduce:

  1. Clone the progress sample repository
  2. Change the increment in progress.report calls to the same value everywhere (25 for example)
  3. Remove the message component in the progress.report calls
  4. Launch the debug and test the extension (obviously)

The progressbar in the notification stays stuck after the first increment, it looks like increments are not taken into account when the same value is sent multiple times in a row. Setting a message seems to fix the problem, even if the message is also the same multiple times in a row.

Does this issue occur when all extensions are disabled? Yes
@roblourens roblourens assigned bpasero and unassigned roblourens May 21, 2018
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities workbench-notifications Notification widget issues labels May 21, 2018
@bpasero bpasero added this to the June 2018 milestone May 21, 2018
@bpasero
Copy link
Member

bpasero commented May 21, 2018

If someone wants to look into this, I would accept a small PR if possible.

@mkavidas
Copy link
Contributor

mkavidas commented May 21, 2018 •
edited

I would like to look into this.

@bpasero What is the desired action for blank messages? I was a little confused. Please take a look at my PR and tell me what you think.

@mkavidas mkavidas mentioned this issue May 22, 2018
Merged
@bpasero bpasero modified the milestones: June 2018, May 2018 May 23, 2018
@bpasero bpasero closed this as completed May 23, 2018
bpasero added a commit that referenced this issue May 23, 2018
@bpasero
follow up for #50190
35be70d
@sbatten sbatten added the verified Verification succeeded label May 31, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug help wanted Issues identified as good community contribution opportunities verified Verification succeeded workbench-notifications Notification widget issues
Projects
None yet
Milestone
May 2018
Development

No branches or pull requests
5 participants
@roblourens @bpasero @sbatten @LaurentTreguier @mkavidas