Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search includes with ** don't match #50311

Closed
roblourens opened this issue May 22, 2018 · 0 comments
Closed

Search includes with ** don't match #50311

roblourens opened this issue May 22, 2018 · 0 comments
Assignees
@roblourens
Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Milestone
May 2018

Comments

@roblourens
Copy link
Member

In Insiders

The reason is that they get resolved to include **/** which doesn't match anything in ripgrep, unless in an absolute glob. Broken now because we search with relative globs instead of absolute.
@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues labels May 22, 2018
@roblourens roblourens added this to the May 2018 milestone May 22, 2018
@roblourens roblourens self-assigned this May 22, 2018
@roblourens roblourens mentioned this issue May 23, 2018
Closed
@octref octref added the verified Verification succeeded label May 31, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Projects
None yet
Milestone
May 2018
Development

No branches or pull requests
2 participants
@roblourens @octref