Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Selected info was not changed with conversion indent character. #50313

Closed
fujitatakesh opened this issue May 23, 2018 · 7 comments
Closed

Selected info was not changed with conversion indent character. #50313

fujitatakesh opened this issue May 23, 2018 · 7 comments
Assignees
@rebornix
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
June 2018

Comments

@fujitatakesh
Copy link

Reproduce steps below..
Step1:
Open a source file with space indented.
Step2:
Select a line with indented.
And selected range info is displayed right side in taskbar.
Step3:
Change space to tab.
Step4:
Selected range info isn't changed before change indent character.
@vscodebot vscodebot bot added editor editor-autoindent Editor auto indentation issues labels May 23, 2018
@weinand
Copy link
Contributor

weinand commented May 23, 2018

I can reproduce.

@rebornix rebornix added bug Issue identified by VS Code Team member as probable bug and removed editor-autoindent Editor auto indentation issues labels Jun 5, 2018
@rebornix
Copy link
Member

rebornix commented Jun 6, 2018

Can you provide more details about how to reproduce? I tried files with spaces, tabs, mixed but can't reproduce.

selected-indent

@rebornix rebornix added the info-needed Issue requires more information from poster label Jun 6, 2018
@fujitatakesh
Copy link
Author

fujitatakesh commented Jun 7, 2018 •
edited

My environment (Mac OS) reproduced. I supposed it depends on some extension.
Can you remove extension and try it again?

@rebornix
Copy link
Member

rebornix commented Jun 7, 2018

I didn't reproduce when running code --disable-extensions, can you try it as well and see if any of your local extensions make it happen?

@fujitatakesh
Copy link
Author

I found to reproduce way is selected range includes line break character.

@rebornix
Copy link
Member

rebornix commented Jun 8, 2018

@fujitatakesh thanks, I can reproduce now

selected-indent

@rebornix rebornix added this to the June 2018 milestone Jun 8, 2018
@rebornix rebornix removed the info-needed Issue requires more information from poster label Jun 8, 2018
@rebornix
Copy link
Member

rebornix commented Jun 8, 2018

To verifiers:

  • Make sure the selection start and end position doesn't change after the indentation conversion when you testing.

@roblourens roblourens added the verified Verification succeeded label Jun 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@rebornix rebornix

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
June 2018
Development

No branches or pull requests
4 participants
@roblourens @rebornix @weinand @fujitatakesh