Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Resolve conflict between (quick) suggestions and snippet placeholders #50776

Closed
vammex opened this issue May 30, 2018 · 4 comments
Closed

Resolve conflict between (quick) suggestions and snippet placeholders #50776

vammex opened this issue May 30, 2018 · 4 comments
Assignees
@jrieken
Labels
feature-request Request for new features or functionality snippets verified Verification succeeded
Milestone
July 2018

Comments

@vammex
Copy link

vammex commented May 30, 2018 •
edited

Issue Type: Performance Issue

impossible ux has been made for executing automatic "for-loop"
i input "i" as iterator and click tab to move to an array determination, but it automatically replaces "i" with smth like id or any other word starting with i
same if i input "j" - it will be replaced with join
first, it's a crazy discomfort
second even i try to fix it manually i miss all quick way to make for-loop using tabs and so on
please fix it, just to avoid automatic replaces inside automatic processes!

VS Code version: Code 1.23.1 (d0182c3, 2018-05-10T17:11:17.614Z)
OS version: Windows_NT x64 10.0.17134

System Info
Item Value
CPUs Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 x 2808)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: disabled_software
video_decode: enabled
video_encode: enabled
vpx_decode: enabled
webgl: enabled
webgl2: enabled
Memory (System) 15.89GB (10.43GB free)
Process Argv C:\Program Files\Microsoft VS Code\Code.exe
Screen Reader no
VM 0%
Process Info 
CPU %	Mem MB	   PID	Process
    0	    93	 12756	code main
    0	   288	  2804	   window (events.js - test27 - Visual Studio Code)
    0	    69	  3296	     extensionHost
    0	    92	  3972	       electron_node electronForkStart.js tsserver.js 
    0	    34	 10436	         electron_node typingsInstaller.js tsserver.js typesMap.js 
    0	    33	  4424	     searchService
    0	    14	  7428	     watcherService 
    0	     8	  7064	       console-window-host (Windows internal process)
    1	    71	  6328	   shared-process
    0	   125	 13276	   gpu-process
    0	    76	 13584	   shared-process
Workspace Info 
|  Window (events.js - test27 - Visual Studio Code)
|    Folder (test27): 230 files
|      File types: png(91) js(85) jpg(11) ttf(8) json(7) html(6) otf(5) css(4)
|                  eot(3) svg(3)
|      Conf files:;
Extensions: none
@jrieken jrieken self-assigned this May 30, 2018
@jrieken jrieken added this to the June 2018 milestone Jun 6, 2018
@jrieken jrieken added polish Cleanup and polish issue verification-needed Verification of issue is requested labels Jun 6, 2018
@jrieken jrieken closed this as completed in ba476a6 Jun 6, 2018
@ramya-rao-a ramya-rao-a mentioned this issue Jun 26, 2018
Closed
@jrieken jrieken reopened this Jun 27, 2018
@jrieken jrieken added under-discussion Issue is under discussion for relevance, priority, approach and removed polish Cleanup and polish issue verification-needed Verification of issue is requested labels Jun 27, 2018
@jrieken jrieken modified the milestones: June 2018, July 2018 Jun 27, 2018
@jrieken
Copy link
Member

jrieken commented Jun 27, 2018

We have reverted the change and restored the old behaviour because of #52999 and #51722

@jrieken jrieken mentioned this issue Jun 27, 2018
Closed
@vammex
Copy link
Author

vammex commented Jun 27, 2018

after all these reverts which way the topis issue will work? with crazy suggestions or not?

@jrieken jrieken reopened this Jun 27, 2018
@jrieken jrieken changed the title for each cycles Resolve conflict between (quick) suggestions and snippet placeholders Jun 29, 2018
@jrieken jrieken mentioned this issue Jul 6, 2018
Closed
jrieken added a commit that referenced this issue Jul 6, 2018
@jrieken
disable quick suggestions when in snippet mode, #50776
bc067a8
jrieken added a commit that referenced this issue Jul 6, 2018
@jrieken
add option editor.suggest.snippetsPreventQuickSuggestions #50776
da4dae4
@jrieken jrieken added feature-request Request for new features or functionality verification-needed Verification of issue is requested and removed under-discussion Issue is under discussion for relevance, priority, approach labels Jul 6, 2018
@jrieken
Copy link
Member

jrieken commented Jul 6, 2018

Next try! The following change has been made (for July insiders). When a snippet is active, quick suggestions (suggestions as you type) are disabled. There is a new setting editor.suggest.snippetsPreventQuickSuggestions with which the old behaviour get be stored.

@jrieken jrieken closed this as completed Jul 6, 2018
@vammex
Copy link
Author

vammex commented Jul 17, 2018

today a new release has been executed.
where is snippetsPreventQuickSuggestions there?

@JacksonKearl JacksonKearl added verified Verification succeeded and removed verification-needed Verification of issue is requested labels Jul 31, 2018
@jrieken jrieken mentioned this issue Aug 15, 2018
Closed
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
feature-request Request for new features or functionality snippets verified Verification succeeded
Projects
None yet
Milestone
July 2018
Development

No branches or pull requests
3 participants
@jrieken @JacksonKearl @vammex