Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add terminal option to expose xterm.js drawBoldTextInBrightColors setting #50895

Closed
Tyriar opened this issue May 31, 2018 · 2 comments
Closed

Add terminal option to expose xterm.js drawBoldTextInBrightColors setting #50895

Tyriar opened this issue May 31, 2018 · 2 comments
Assignees
@Tyriar
Labels
feature-request Request for new features or functionality terminal Integrated terminal issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone
June 2018

Comments

@Tyriar
Copy link
Member

Tyriar commented May 31, 2018

No description provided.

@Tyriar Tyriar added feature-request Request for new features or functionality terminal Integrated terminal issues labels May 31, 2018
@Tyriar Tyriar added this to the June 2018 milestone May 31, 2018
@Tyriar Tyriar self-assigned this May 31, 2018
@Tyriar Tyriar closed this as completed in 1f0ecfa Jun 12, 2018
@Tyriar Tyriar added the verification-needed Verification of issue is requested label Jun 25, 2018
@Tyriar
Copy link
Member Author

Tyriar commented Jun 25, 2018

To verify, on Linux/macOS add this to settings:

  "workbench.colorCustomizations": {
    "terminal.ansiRed": "#ff0000",
    "terminal.ansiBrightRed": "#00ff00"
  },

Then run echo -e '\x1b[31mnormal \x1b[1mbold' under the following two configurations:

  • "terminal.integrated.drawBoldTextInBrightColors": true - This should show red then green
  • "terminal.integrated.drawBoldTextInBrightColors": false - This should show red for both words

@RMacfarlane RMacfarlane added the verified Verification succeeded label Jun 27, 2018
@Tyriar
Copy link
Member Author

Tyriar commented Jun 29, 2018

Upstream: xtermjs/xterm.js#1391

@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
feature-request Request for new features or functionality terminal Integrated terminal issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
June 2018
Development

No branches or pull requests
2 participants
@Tyriar @RMacfarlane