Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notifications: Updating message recreates notification (drops progress bar) #50931

Closed
jrieken opened this issue Jun 1, 2018 · 2 comments
Closed

Notifications: Updating message recreates notification (drops progress bar) #50931

jrieken opened this issue Jun 1, 2018 · 2 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug verification-needed Verification of issue is requested verified Verification succeeded workbench-notifications Notification widget issues
Milestone
March 2020

Comments

@jrieken
Copy link
Member

jrieken commented Jun 1, 2018

this continues #50479. as said here there still a few cases missing, esp. 2 looks weird. It seems like the message is interpreted as some kind of default increment, I'd expect an infinite progress in the absence of discrete increments.

jun-01-2018 11-17-25

        await vscode.window.withProgress(
            {
                location: vscode.ProgressLocation.Notification,
                title: "Test 2: report only message"
            },
            async (progress) => {
                await wait1();
                for (let i = 0; i < 10; ++i) {
                    progress.report({ message: `message ${i}` });
                    await wait2();
                }
            });
@jrieken jrieken added the bug Issue identified by VS Code Team member as probable bug label Jun 1, 2018
@jrieken jrieken mentioned this issue Jun 1, 2018
Closed
@bpasero bpasero added the workbench-notifications Notification widget issues label Jun 1, 2018
@bpasero bpasero changed the title window.withProgress doesn't update properly Updating progress title resets infinite progress all the time Jun 1, 2018
bpasero added a commit that referenced this issue Apr 4, 2019
@bpasero
notifications - make #50931 a bit better
a668b4f
@bpasero
Copy link
Member

bpasero commented Apr 4, 2019 •
edited

Pushed a change that "fixes" this when the notification is collapsed (which it is by default) because then we notification has a fixed height independent of the content and we can just update the message text directly without splicing the list.

If a notification is expanded the challenge is to adjust the height of the list item (that is used to render notifications) without splicing the item from the list (which is currently not possible). And splicing currently removes the spinning progress from the DOM and adds it back which unfortunately means the animation always starts at 0 again.

@bpasero bpasero mentioned this issue Feb 27, 2020
Closed
@bpasero bpasero changed the title Updating progress title resets infinite progress all the time Notifications: Updating message or buttons recreates notification (drops progress bar) Feb 27, 2020
@bpasero bpasero changed the title Notifications: Updating message or buttons recreates notification (drops progress bar) Notifications: Updating message recreates notification (drops progress bar) Feb 29, 2020
@bpasero bpasero added this to the March 2020 milestone Feb 29, 2020
bpasero added a commit that referenced this issue Feb 29, 2020
@bpasero
Notifications: Updating message recreates notification (drops progres…
b185dd4 
…s bar) (fix #50931)
@bpasero bpasero closed this as completed in 6f7c9f3 Mar 2, 2020
@bpasero bpasero added the verification-needed Verification of issue is requested label Mar 2, 2020
@bpasero
Copy link
Member

bpasero commented Mar 2, 2020

Verification: please look at #50931 (comment) but craft a message that will cause the notification to wrap (i.e. has long text). We still want the notification to grow in height when text overflows.

@connor4312 connor4312 added the verified Verification succeeded label Apr 1, 2020
@github-actions github-actions bot locked and limited conversation to collaborators Apr 16, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug verification-needed Verification of issue is requested verified Verification succeeded workbench-notifications Notification widget issues
Projects
None yet
Milestone
March 2020
Development

No branches or pull requests
3 participants
@bpasero @jrieken @connor4312