Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Black bar appears in terminal "empty rows" when its resized #51094

Closed
octref opened this issue Jun 4, 2018 · 20 comments
Closed

Black bar appears in terminal "empty rows" when its resized #51094

octref opened this issue Jun 4, 2018 · 20 comments
Assignees
@Tyriar
Labels
bug Issue identified by VS Code Team member as probable bug electron Issues and items related to Electron terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone
December/January ...

Comments

@octref
Copy link
Contributor

octref commented Jun 4, 2018

Issue Type: Bug

  • Run tsc --watch
  • Terminal split

image

VS Code version: Code - Insiders 1.24.0-insider (9275422, 2018-06-01T13:37:15.690Z)
OS version: Darwin x64 17.5.0

System Info
Item Value
CPUs Intel(R) Core(TM) i7-4770HQ CPU @ 2.20GHz (8 x 2200)
GPU Status 2d_canvas: enabled
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
rasterization: enabled
video_decode: enabled
video_encode: enabled
vpx_decode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 3, 2, 2
Memory (System) 16.00GB (0.98GB free)
Process Argv /Applications/Visual Studio Code - Insiders.app/Contents/MacOS/Electron -psn_0_1364301
Screen Reader no
VM 0%
Extensions (14)
Extension Author (truncated) Version
markdown-emoji bie 0.0.7
tslint eg2 1.0.30
vsc-material-theme Equ 2.1.0
prettier-vscode esb 1.4.0
theme-monokai-pro-vscode mon 1.1.6
vscode-scss mrm 0.6.2
debugger-for-chrome msj 4.5.0
vetur oct 0.12.3
vscode-proun oct 0.0.1
polacode pnp 0.2.2
vscode-sort-json ric 1.11.0
vscode-csstree sme 0.7.0
language-stylus sys 1.9.2
vim vsc 0.12.0

(2 theme extensions excluded)
@octref octref added the terminal Integrated terminal issues label Jun 4, 2018
@vscodebot vscodebot bot added the insiders label Jun 4, 2018
@octref octref removed the insiders label Jun 4, 2018
@octref
Copy link
Contributor Author

octref commented Jun 4, 2018

The shadowy scorllbar persists even after closing split terminal.

image

@octref octref added this to the May 2018 milestone Jun 4, 2018
@chrmarti
Copy link
Contributor

chrmarti commented Jun 5, 2018

Removing from May milestone after checking with @Tyriar.

@chrmarti chrmarti removed this from the May 2018 milestone Jun 5, 2018
@Tyriar Tyriar added the bug Issue identified by VS Code Team member as probable bug label Jun 6, 2018
@Tyriar
Copy link
Member

Tyriar commented Jun 6, 2018

@bgw any idea what this could be? It appears to be a recent regression:

kapture 2018-06-06 at 5 22 27

@bgw
Copy link

bgw commented Jun 6, 2018 •
edited

😕 😱 Given the artifacts that's manifesting with, this looks like it might be an electron/chromium bug, and not an xterm.js bug. We shouldn't even be doing any drawing work (aside from the initial background fill) to regions without text...

This is with the canvas renderer, right?

@Tyriar
Copy link
Member

Tyriar commented Jun 6, 2018

@bgw yes this is the canvas renderer. My first impression was it's a Chromium thing but it looks like the black columns are lining up with the terminal columns which makes me think it's our bug.

@Tyriar Tyriar added this to the May 2018 Recovery milestone Jun 11, 2018
@Tyriar Tyriar added the candidate Issue identified as probable candidate for fixing in the next release label Jun 11, 2018
@Tyriar
Copy link
Member

Tyriar commented Jun 11, 2018

Updating to latest xterm.js doesn't appear to fix this.

@Tyriar
Copy link
Member

Tyriar commented Jun 12, 2018

May be related to #51602

@Tyriar
Copy link
Member

Tyriar commented Jun 12, 2018 •
edited

It's definitely the text layer that has the issue.

@Tyriar
Copy link
Member

Tyriar commented Jun 12, 2018 •
edited

This is looking more and more like a Chromium bug. If I change this line to be #FF0000, I do not get the bars. changing it to #888888 however and I do:

https://github.com/xtermjs/xterm.js/blob/1487b8d02d42a3aef6b7225d7745bbc488015aaa/src/renderer/BaseRenderLayer.ts#L177

screen shot 2018-06-12 at 1 01 46 pm

screen shot 2018-06-12 at 1 02 09 pm

@Tyriar
Copy link
Member

Tyriar commented Jun 12, 2018 •
edited

Moving to June as it appears to be a Chrome issue, needs a workaround inside xterm.js and it's less impact than I first thought. It only impacts "null" rows, this does not happen when the viewport has been filled (you see a flicker but it goes away the next frame).

@Tyriar Tyriar removed the candidate Issue identified as probable candidate for fixing in the next release label Jun 12, 2018
@Tyriar Tyriar modified the milestones: May 2018 Recovery, June 2018 Jun 12, 2018
@Tyriar Tyriar closed this as completed in b0e2d1d Jun 12, 2018
@bgw
Copy link

bgw commented Jun 12, 2018

@Tyriar, what was the workaround for this?

Tyriar added a commit that referenced this issue Jun 13, 2018
@Tyriar
Revert workaround for black bar in terminal
d901821 
Fixes #51749
See #51094
@Tyriar
Copy link
Member

Tyriar commented Jun 13, 2018

@bgw the workaround didn't fix it, I tried to use clearRect in TextRenderLayer.onGridChanged which seemed to work on macOS, but didn't on other platforms #51749 (comment)

@Tyriar Tyriar reopened this Jun 13, 2018
@Tyriar
Copy link
Member

Tyriar commented Jun 21, 2018

Can't repro this out of sources anymore 😕

@Tyriar Tyriar removed this from the June 2018 milestone Jun 21, 2018
@Tyriar Tyriar added this to the July 2018 milestone Jun 21, 2018
@octref
Copy link
Contributor Author

octref commented Jun 21, 2018

I'm on e585e4b

glitch

@Tyriar
Copy link
Member

Tyriar commented Jun 21, 2018

Yeah I see it in insiders, no running out of sources though 😕

@Tyriar Tyriar mentioned this issue Jun 26, 2018
Closed
@Tyriar
Copy link
Member

Tyriar commented Jun 26, 2018

I've also seen this happen:

screen shot 2018-06-26 at 12 56 41 pm

@Tyriar Tyriar changed the title Terminal Glitch when splitting from tsc --watch Black bar appears in terminal "empty rows" when its resized Jun 26, 2018
@Tyriar Tyriar modified the milestones: July 2018, Backlog Jun 26, 2018
@Tyriar Tyriar added upstream Issue identified as 'upstream' component related (exists outside of VS Code) electron Issues and items related to Electron labels Jun 26, 2018
@Tyriar
Copy link
Member

Tyriar commented Jun 26, 2018

Something similar can also happen in the color picker:

image

@Tyriar
Copy link
Member

Tyriar commented Sep 7, 2018

I think this one is fixed in Electron 3

@Tyriar
Copy link
Member

Tyriar commented Nov 23, 2018

This is also fixed by the webgl renderer I just build xtermjs/xterm.js#1790, not sure if we would ship that before Electron 3 though.

@bpasero
Copy link
Member

bpasero commented Jan 25, 2019

Closing this issue given that we plan to release VSCode stable early February with Electron 3.x. If you want to benefit from the fix already, consider to use our insiders version that already contains the fix: https://code.visualstudio.com/insiders/

@bpasero bpasero closed this as completed Jan 25, 2019
@mjbvz mjbvz added the verified Verification succeeded label Jan 31, 2019
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Tyriar Tyriar

Labels
bug Issue identified by VS Code Team member as probable bug electron Issues and items related to Electron terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Milestone
December/January 2019
Development

No branches or pull requests
6 participants
@bgw @bpasero @Tyriar @octref @chrmarti @mjbvz