Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[loc][Query][VSCode] Please clarify whether this should be locked "{0}, git branch" #5159

Closed
mkyjakova opened this issue Apr 11, 2016 · 9 comments
Closed

[loc][Query][VSCode] Please clarify whether this should be locked "{0}, git branch" #5159

mkyjakova opened this issue Apr 11, 2016 · 9 comments
Assignees
@bpasero
Labels
info-needed Issue requires more information from poster
Milestone
Backlog

Comments

@mkyjakova
Copy link

Hi, we have a query about a string in the English text. Can you please help?

Source:
{0}, git branch

File Name:
src\vs\workbench\parts\git\browser\gitQuickOpen.nls.resx

Resource ID:
".resx", 0; "branchAriaLabel"

Query:
This seems to be a git command. Should it have been locked? Thanks!
@mkyjakova mkyjakova changed the title [loc][Query][VSCode] Please clarify placeholder "{0}, git branch" [loc][Query][VSCode] Please clarify whether this should be locked "{0}, git branch" Apr 11, 2016
@joaomoreno joaomoreno assigned bpasero and unassigned joaomoreno Apr 11, 2016
@joaomoreno
Copy link
Member

@bpasero check this, it is aria

@bpasero bpasero added this to the April 2016 milestone Apr 11, 2016
@bpasero
Copy link
Member

bpasero commented Apr 11, 2016

@mkyjakova for example "master, git branch". the first part is the branch name and the second just an explanation for screen readers.

@mkyjakova
Copy link
Author

Thanks! So if I understand correctly, it should not be locked. Correct?

@mkyjakova mkyjakova reopened this Apr 12, 2016
@bpasero
Copy link
Member

bpasero commented Apr 12, 2016

What do you mean by locked?

@bpasero bpasero added the info-needed Issue requires more information from poster label Apr 13, 2016
@bpasero bpasero modified the milestones: Backlog, April 2016 Apr 13, 2016
@bpasero
Copy link
Member

bpasero commented Apr 14, 2016

Ping me on Lync please if you need further help :)

@bpasero bpasero closed this as completed Apr 14, 2016
@mkyjakova
Copy link
Author

Thanks for asking! Git commands have to be locked by the core team in order to remain in English. If they are not locked, our translators translate them as regular words.
So my question here is whether this is a git command (because it looks like one) or not. If it is, it should be locked so that it is not translated. Hopefully, this makes more sense, if not please let me know. Thanks!

@bpasero
Copy link
Member

bpasero commented Apr 14, 2016

I think it would be good to keep "Git" untranslated.

@joaomoreno
Copy link
Member

No, it is not a git command. It is used for screen reading: it informs the user that {0} is a branch coming from a git repository.

But really nice of you to stay alert to these type of things. 👍

@mkyjakova
Copy link
Author

Great. Thanks both :)

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
info-needed Issue requires more information from poster
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
3 participants
@joaomoreno @bpasero @mkyjakova