Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependsOn is no longer working #51627

Closed
IAmHopp opened this issue Jun 11, 2018 · 4 comments
Closed

dependsOn is no longer working #51627

IAmHopp opened this issue Jun 11, 2018 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug tasks Task system issues verified Verification succeeded
Milestone

Comments

@IAmHopp
Copy link

IAmHopp commented Jun 11, 2018

Issue Type: Bug

Hi,

I have a set of tasks defined for everyday use, the build one being a series of tasks linked via dependsOn. Due to one of the recent builds [don't know if it was today's, I don't think I built anything on friday], tasks with dependsOn are no longer working on my machine.

This simple scenario, for example, fails:

tasks.json

[...]
        {
            "command": "Write-Host 'Second'",
            "dependsOn": "First",
            "group":
            {
                "isDefault": true,
                "kind": "build"
            },
            "label": "Second",
            "type": "shell"
        },
        {
            "command": "Write-Host 'First'",
            "label": "First",
            "type": "shell"
        }
[...]

Running the task Second without dependsOn works and "Second" is correctly outputted. Running with dependsOn errors out with the following Tasks output:

Cannot read property 'type' of undefined

I can verify this still works as intended on 1.24.0. Any guidance here would be appreciated.

VS Code version: Code - Insiders 1.25.0-insider (28d5806, 2018-06-11T05:17:42.700Z)
OS version: Windows_NT x64 10.0.17134

System Info
Item Value
CPUs Intel(R) Core(TM) i7-7700 CPU @ 3.60GHz (8 x 3600)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: disabled_software
rasterization: enabled
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
Memory (System) 15.88GB (5.38GB free)
Process Argv C:\Program Files\Microsoft VS Code Insiders\Code - Insiders.exe
Screen Reader no
VM 0%
Extensions (9)
Extension Author (truncated) Version
gitlens eam 8.3.5
mssql ms- 1.3.1
team ms- 1.136.0
java red 0.26.0
vscode-java-debug vsc 0.9.0
vscode-java-pack vsc 0.3.0
vscode-java-test vsc 0.6.1
vscode-maven vsc 0.9.0
html-css-class-completion Zig 1.17.1
@vscodebot
Copy link

vscodebot bot commented Jun 11, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot added the tasks Task system issues label Jun 11, 2018
@dbaeumer
Copy link
Member

@IAmHopp thanks for the issue report. I am able to reproduce. Very likely caused by allowing task identifiers in dependsOn property.

@dbaeumer
Copy link
Member

@IAmHopp found the problem. Will fix it. If you need to work around it you can make the dependsOn an array in which case it will work correctly.

@IAmHopp
Copy link
Author

IAmHopp commented Jun 12, 2018

Thanks, man.

@dbaeumer dbaeumer added the bug Issue identified by VS Code Team member as probable bug label Jun 13, 2018
@dbaeumer dbaeumer added this to the June 2018 milestone Jun 13, 2018
@roblourens roblourens added the verified Verification succeeded label Jun 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 27, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug tasks Task system issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants
@roblourens @dbaeumer @IAmHopp and others