Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Git icon not "spinning" when pushing from command palette #51677

Closed
ErlendEllingsen opened this issue Jun 12, 2018 · 2 comments
Closed

Git icon not "spinning" when pushing from command palette #51677

ErlendEllingsen opened this issue Jun 12, 2018 · 2 comments
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities verified Verification succeeded
Milestone
June 2018

Comments

@ErlendEllingsen
Copy link

ErlendEllingsen commented Jun 12, 2018 •
edited

  • VSCode Version: 1.23.0
  • OS Version: Windows 10

Steps to Reproduce:

  1. Push to git from command palette instead of clicking the visual icon
  2. Icon will not "spin" as it does when clicking it.

The refresher / spinner icon is a nice indicator that a git action is being performed. When pushing from command palette there is no real indication that any action is going on in the bottom left area.

Does this issue occur when all extensions are disabled?: Yes/No
Yes
@vscodebot vscodebot bot added the git GIT issues label Jun 12, 2018
@joaomoreno
Copy link
Member

The spinning icon only spins when the Sync command runs, not Pull or Push.

@joaomoreno joaomoreno added the bug Issue identified by VS Code Team member as probable bug label Jun 12, 2018
@joaomoreno joaomoreno added this to the Backlog milestone Jun 12, 2018
@joaomoreno joaomoreno added help wanted Issues identified as good community contribution opportunities good first issue Issues identified as good for first-time contributors labels Jun 12, 2018
@frozzare frozzare mentioned this issue Jun 12, 2018
Closed
@mvgadagi
Copy link

mvgadagi commented Jun 15, 2018 •
edited

I am working on this bug, But I am not able to reproduce this issue, Kindly confirm again

Before Pushing from Command Palette
image

After Pushing from Command Palette I am able to see the refresh icon
image

Version Details

Version: 1.25.0
Commit: Unknown
Date: Unknown
Electron: 2.0.2
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
Architecture: x64

@NahomAgidew NahomAgidew mentioned this issue Jun 18, 2018
Merged
@joaomoreno joaomoreno modified the milestones: Backlog, June 2018 Jun 18, 2018
@roblourens roblourens added the verified Verification succeeded label Jun 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug git GIT issues good first issue Issues identified as good for first-time contributors help wanted Issues identified as good community contribution opportunities verified Verification succeeded
Projects
None yet
Milestone
June 2018
Development

Successfully merging a pull request may close this issue.

git: Spin sync icon on push and pull frozzare/vscode
4 participants
@joaomoreno @roblourens @ErlendEllingsen @mvgadagi