Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workbench grid should respect editor dimension constraints #51964

Closed
bpasero opened this issue Jun 15, 2018 · 0 comments · Fixed by #51989
Closed

Workbench grid should respect editor dimension constraints #51964

bpasero opened this issue Jun 15, 2018 · 0 comments · Fixed by #51989
Assignees
@joaomoreno @bpasero
Labels
bug Issue identified by VS Code Team member as probable bug layout General VS Code workbench layout issues verified Verification succeeded
Milestone
June 2018

Comments

@bpasero
Copy link
Member

bpasero commented Jun 15, 2018 •
edited

When sizing settings small enough (by having a grid to the right and making that large), the settings editor is no longer shrinking making it fall out of the grid:

image

Maybe related to the recent changes to adopt splitview for side by side editor?

in stable:

image
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug layout General VS Code workbench layout issues labels Jun 15, 2018
@joaomoreno joaomoreno assigned bpasero and unassigned sandy081 Jun 15, 2018
@joaomoreno joaomoreno added this to the June 2018 milestone Jun 15, 2018
@joaomoreno joaomoreno changed the title Resize behaviour of settings editor is now broken Workbench grid should respect editor dimension constraints Jun 15, 2018
joaomoreno added a commit that referenced this issue Jun 15, 2018
@joaomoreno
side by side editor dimension constraints
3e243a2 
related to #51964
joaomoreno added a commit that referenced this issue Jun 15, 2018
@joaomoreno
preferences editor dimension constraints
8c458da 
fixes #51964
@joaomoreno joaomoreno mentioned this issue Jun 15, 2018
Merged
6 tasks
@RMacfarlane RMacfarlane added the verified Verification succeeded label Jun 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Jul 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug layout General VS Code workbench layout issues verified Verification succeeded
Projects
None yet
Milestone
June 2018
Development

Successfully merging a pull request may close this issue.

Workbench grid dimension constraint propagation microsoft/vscode
4 participants
@joaomoreno @bpasero @RMacfarlane @sandy081