Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Touchbar on Macbook no longer showing #52045

Closed
jeffhollan opened this issue Jun 15, 2018 · 5 comments
Closed

Touchbar on Macbook no longer showing #52045

jeffhollan opened this issue Jun 15, 2018 · 5 comments
Assignees
@bpasero
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority macos Issues with VS Code on MAC/OS X verified Verification succeeded
Milestone
June 2018

Comments

@jeffhollan
Copy link

Issue Type: Bug

Open latest version of code-insiders, and the touchbar doesn't show the regular commands (start debugging button). I also had an extension I had installed previously to add extra buttons to touchbar, but even disabling or uninstalling that extension doesn't bring the touchbar back. Have tried rebooting machine as well. It still works on code (non-insiders)

VS Code version: Code - Insiders 1.25.0-insider (7dc9539, 2018-06-15T05:12:05.222Z)
OS version: Darwin x64 17.6.0

System Info
Item Value
CPUs Intel(R) Core(TM) i7-7700HQ CPU @ 2.80GHz (8 x 2800)
GPU Status 2d_canvas: enabled
checker_imaging: disabled_off
flash_3d: enabled
flash_stage3d: enabled
flash_stage3d_baseline: enabled
gpu_compositing: enabled
multiple_raster_threads: enabled_on
native_gpu_memory_buffers: enabled
rasterization: enabled
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
Load (avg) 3, 3, 3
Memory (System) 16.00GB (0.10GB free)
Process Argv /Applications/Visual Studio Code - Insiders.app/Contents/MacOS/Electron -psn_0_446573
Screen Reader no
VM 22%
Extensions (16)
Extension Author (truncated) Version
bracket-pair-colorizer Coe 1.0.58
gitlens eam 8.3.5
vscode-azureeventgrid ms- 0.1.0
vscode-azurefunctions ms- 0.9.1
vscode-azurestorage ms- 0.3.1
vscode-cosmosdb ms- 0.7.2
python ms- 2018.5.0
azure-account ms- 0.4.0
csharp ms- 1.15.2
Go ms- 0.6.82
vetur oct 0.12.5
vscode-docker Pet 0.0.27
java red 0.26.0
code-settings-sync Sha 2.9.2
azure-iot-edge vsc 0.4.0
azure-iot-toolkit vsc 0.6.3

(1 theme extensions excluded)
@vscodebot
Copy link

vscodebot bot commented Jun 15, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot added the extensions Issues concerning extensions label Jun 15, 2018
@RMacfarlane RMacfarlane added the macos Issues with VS Code on MAC/OS X label Jun 15, 2018
@RMacfarlane RMacfarlane added bug Issue identified by VS Code Team member as probable bug and removed extensions Issues concerning extensions labels Jun 15, 2018
@bpasero
Copy link
Member

bpasero commented Jun 16, 2018

Related to the electron update it seems....

@bpasero bpasero added upstream Issue identified as 'upstream' component related (exists outside of VS Code) important Issue identified as high-priority and removed electron-update upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Jun 16, 2018
@bpasero bpasero added this to the June 2018 milestone Jun 16, 2018
@bpasero
Copy link
Member

bpasero commented Jun 16, 2018 •
edited

This is a regression from @alexandrudima change in 8810c8e where we seem to have introduced URIs and now start to send a URI over to the updateTouchBar method.

bpasero added a commit that referenced this issue Jun 17, 2018
@bpasero
fix #52045
3f42617
@alexdima
Copy link
Member

Sorry about that @bpasero

I didn't realize ICommandAction was being serialized.

@bpasero
Copy link
Member

bpasero commented Jun 18, 2018

Fixed by introducing a ISerializableCommandAction using UriComponents

@RMacfarlane RMacfarlane added the verified Verification succeeded label Jun 29, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority macos Issues with VS Code on MAC/OS X verified Verification succeeded
Projects
None yet
Milestone
June 2018
Development

No branches or pull requests
4 participants
@bpasero @RMacfarlane @alexdima @jeffhollan