Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revisit sensitive window split / group behavior on drag and drop #52063

Closed
inarius opened this issue Jun 15, 2018 · 2 comments
Closed

Revisit sensitive window split / group behavior on drag and drop #52063

inarius opened this issue Jun 15, 2018 · 2 comments
Assignees
@bpasero
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded workbench-editor-grid Grid layout issues in the editor area
Milestone
June 2018

Comments

@inarius
Copy link

inarius commented Jun 15, 2018

Issue Type: Feature Request

I have noticed what seems like a recent change in the behavior for grouping/splitting windows when dragging and dropping files into the main editor. I often use this method to open files.

I am now frequently splitting the window at unintended times when I open new files. I believe the target area that triggers a split window is too large, especially when not using VSCode maximized, or on smaller screens.

VS Code version: Code - Insiders 1.25.0-insider (11b0f3a, 2018-06-14T05:17:21.496Z)
OS version: Windows_NT x64 10.0.15063

vccode-sensitive-docking
@RMacfarlane RMacfarlane added the workbench-editor-grid Grid layout issues in the editor area label Jun 15, 2018
@bpasero bpasero added this to the June 2018 milestone Jun 15, 2018
@bpasero bpasero changed the title Sensitive window split / group behavior on drag and drop Revisit sensitive window split / group behavior on drag and drop Jun 16, 2018
@bpasero
Copy link
Member

bpasero commented Jun 16, 2018

The current threshold is 30% of width with is a lot more compared to stable (10%). I also think we should optimize for the preferred direction of the user. E.g. when the configured to split to the right, we should maybe make the hitzone for splitting into that direction larger and vice versa.

@bpasero bpasero added feature-request Request for new features or functionality verification-needed Verification of issue is requested labels Jun 16, 2018
@bpasero
Copy link
Member

bpasero commented Jun 18, 2018 •
edited

Pushed 2 changes to improve this:

  • reduced the threshold where we account for a split to 20% (making the center as large as 60% to add the file into the group as opposed to causing a split
  • making the hitzone for vertical or horizontal split larger depending on the workbench.editor.openSideBySideDirection

"workbench.editor.openSideBySideDirection": "right" (default)
image

"workbench.editor.openSideBySideDirection": "down"
image

//cc @jrieken this should make it easier to reorder groups vertically as before. you can leave the mouse towards the top of the group and trigger the move to the left or right hand side without having to go down with the mouse

grid-tw

@isidorn isidorn added the verified Verification succeeded label Jun 27, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded workbench-editor-grid Grid layout issues in the editor area
Projects
None yet
Milestone
June 2018
Development

No branches or pull requests
4 participants
@bpasero @isidorn @RMacfarlane @inarius