Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick pick should announce how many results are genered after pressing a character #52542

Closed
AccessibilityTestingTeam-TCS opened this issue Jun 21, 2018 · 9 comments
Closed

Quick pick should announce how many results are genered after pressing a character #52542

AccessibilityTestingTeam-TCS opened this issue Jun 21, 2018 · 9 comments
Assignees
@chrmarti
Labels
a11ymas Issue from accessibility team accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues verified Verification succeeded windows VS Code on Windows issues
Milestone
July 2018

Comments

@AccessibilityTestingTeam-TCS
Copy link

Environment Details:
VSCode Version : 1.24.0
OS Version : Win10

Additional Details:
Screenreader,NVDA[2018.2],MAS1.3.1

Repro Steps:
1.Navigate to Status Bar and select "Select Language Mode" button.
2.Enter some data in the editor it shows some result related to entered data.
3.Observed that NVDA is not announcing the generated result.

Actual:
If the user enter letter "s" then all list which contains "s" will display.
But the nvda is reading only entered data of text editor.

Expected:
If the user enter letter "s" then all list which contains "s" will display.
then nvda should reads/announcing the how many results are generated after entering "s".

Recommendations:
Refer below link which is repository of bug fixes code snippets:
https://microsoft.sharepoint.com/teams/msenable/mas/Pages/browse-fixes.aspx

User Impact:
User will not understand how many results are generated on entered data.

MAS Reference:
MAS1.3.1: https://microsoft.sharepoint.com/:w:/r/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={54f28d1f-a2d1-4dcd-84e1-5c9b87e8aba4}

Attachment For Reference:
[Accessibility]A11y_VSCode_LangMode_Screenreader.pptx

Does this issue occur when all extensions are disabled?: Yes
@vscodebot
Copy link

vscodebot bot commented Jun 21, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot added editor editor-contrib Editor collection of extras labels Jun 21, 2018
@chrmarti chrmarti self-assigned this Jun 21, 2018
@chrmarti chrmarti added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues quick-pick Quick-pick widget issues and removed editor editor-contrib Editor collection of extras labels Jun 21, 2018
This was referenced Jul 4, 2018
Closed
Closed
@isidorn isidorn changed the title [Accessibility]A11y_VSCode_LangMode_Screenreader: After entering the data in editor NVDA is not announcing the result. Quick pick should announce how many results are genered after pressing a character Jul 4, 2018
@isidorn isidorn mentioned this issue Jul 4, 2018
Closed
@isidorn
Copy link
Contributor

isidorn commented Jul 4, 2018

QuickPick usualy has hunderds if not thousands of results. I see no value in the user knowing what is that number. We could maybe read it out only if lower than some number.

I feel like this should be closed as designed
@bpasero let me know what you think

@isidorn isidorn added info-needed Issue requires more information from poster under-discussion Issue is under discussion for relevance, priority, approach labels Jul 4, 2018
@bpasero
Copy link
Member

bpasero commented Jul 4, 2018

Unsure, maybe we should have an ARIA-Alert whenever the results come back. I think its a good idea to have some way of informing the user that a search is done.

@isidorn
Copy link
Contributor

isidorn commented Jul 4, 2018

In practice results come instantaniously. Thought we could experiment with an alert for the number of items. Might be noise. Let's assign to July

@isidorn isidorn added this to the July 2018 milestone Jul 4, 2018
@bpasero
Copy link
Member

bpasero commented Jul 4, 2018

@isidorn

In practice results come instantaniously.

Maybe for our pickers, but we cannot tell for extensions that use the picker.

@isidorn isidorn mentioned this issue Jul 4, 2018
Closed
@chrmarti
Copy link
Contributor

chrmarti commented Jul 9, 2018

Only the new API for pickers will allow for extensions to update the list at all (and with delay). I expect quick results to remain the common case. That might result in an announcement after each keystroke, if I understand the proposed change correctly.

@AccessibilityTestingTeam-TCS
Copy link
Author

Here Screenreader should announced the count, that how many numbers of reults are generated related to entered letter please refer the attached video too.

@chrmarti
Copy link
Contributor

Using "aria-live"="polite", that is read only when its text changes (here the number of results).

@isidorn
Copy link
Contributor

isidorn commented Jul 27, 2018

Adding bug label so we verify this in endgame

@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster under-discussion Issue is under discussion for relevance, priority, approach labels Jul 27, 2018
@mjbvz mjbvz mentioned this issue Aug 2, 2018
Closed
@mjbvz mjbvz added the verified Verification succeeded label Aug 2, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 10, 2018
@chrmarti chrmarti added the a11ymas Issue from accessibility team label Oct 2, 2018
@isidorn isidorn added the windows VS Code on Windows issues label Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@chrmarti chrmarti

Labels
a11ymas Issue from accessibility team accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues verified Verification succeeded windows VS Code on Windows issues
Projects
None yet
Milestone
July 2018
Development

No branches or pull requests
5 participants
@bpasero @isidorn @chrmarti @mjbvz @AccessibilityTestingTeam-TCS