Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabled actions should be read as "disabled" #52577

Closed
AccessibilityTestingTeam-TCS opened this issue Jun 21, 2018 · 4 comments
Closed

Disabled actions should be read as "disabled" #52577

AccessibilityTestingTeam-TCS opened this issue Jun 21, 2018 · 4 comments
Assignees
@roblourens
Labels
a11ymas Issue from accessibility team accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug macos Issues with VS Code on MAC/OS X verified Verification succeeded
Milestone
September 2018

Comments

@AccessibilityTestingTeam-TCS
Copy link

Environment Details:*
VSCode Version : 1.24.0
OS Version : Win10

Additional Details:
MAS Violated : MAS 1.3.1
ScreenReader Versions : NVDA2018.1.1 / JAWS18.0.5038

Repro Steps:

  1. Launch VS Code while NVDA/JAWS is ON.
  2. Navigate to Activity Bar and select "Search"(Cntrl+Shift+F) button.
  3. Navigate to disabled buttons above Search text field - "Refresh" , "Collapse All ", "Clear".

Actual:
Screenreader does not read the state of the disabled buttons above Search text field - "Refresh" , "Collapse All ", "Clear" as "disabled".

Same issue has been observed with NVDA.

Expected:
Screenreader should read the state of the disabled buttons above Search text field - "Refresh" , "Collapse All ", "Clear" as "disabled".

Recommendations:
Refer below link which is repository of bug fixes code snippets:
https://microsoft.sharepoint.com/teams/msenable/mas/pages/browse-fixes.aspx

User Impact:
Screenreader users will not know about the state of the button and its availability for use.

MAS Reference:
MAS 1.3.1 - https://microsoft.sharepoint.com/teams/msenable/_layouts/15/WopiFrame.aspx?sourcedoc={54f28d1f-a2d1-4dcd-84e1-5c9b87e8aba4}

Attachment for Reference:
A11y_VSCode_ViewSearch_ScreenReader_Disabled.pptx

Does this issue occur when all extensions are disabled?: Yes
@vscodebot
Copy link

vscodebot bot commented Jun 21, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@vscodebot vscodebot bot added the search Search widget and operation issues label Jun 21, 2018
@AccessibilityTestingTeam-TCS AccessibilityTestingTeam-TCS changed the title A11y_VSCode_ViewSearch_ScreenReader: Screenreader does not read the state of the disabled buttons(Refresh,Collapse All,Clear). [Accessibility]A11y_VSCode_ViewSearch_ScreenReader: Screenreader does not read the state of the disabled buttons(Refresh,Collapse All,Clear). Jun 21, 2018
@isidorn isidorn changed the title [Accessibility]A11y_VSCode_ViewSearch_ScreenReader: Screenreader does not read the state of the disabled buttons(Refresh,Collapse All,Clear). Disable actions should be read as "disabled" Jul 4, 2018
@isidorn isidorn added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues and removed search Search widget and operation issues labels Jul 4, 2018
@isidorn isidorn changed the title Disable actions should be read as "disabled" Disabled actions should be read as "disabled" Jul 4, 2018
@isidorn
Copy link
Contributor

isidorn commented Jul 4, 2018

This is a general workbench issue, renaming. Assigning to july to investigate
fyi @bpasero

@isidorn isidorn added this to the July 2018 milestone Jul 4, 2018
@isidorn isidorn added the under-discussion Issue is under discussion for relevance, priority, approach label Jul 4, 2018
@bpasero
Copy link
Member

bpasero commented Jul 4, 2018 •
edited

I agree, ideally there is an ARIA role we could set for disabled buttons etc. If that does not work in VoiceOver and NVDA, we should update the label.

@isidorn isidorn mentioned this issue Jul 5, 2018
Closed
@roblourens roblourens modified the milestones: July 2018, August 2018 Aug 2, 2018
@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug and removed under-discussion Issue is under discussion for relevance, priority, approach labels Sep 1, 2018
@jrieken jrieken added the verified Verification succeeded label Sep 26, 2018
@jrieken
Copy link
Member

jrieken commented Sep 26, 2018

verified tho it now skips those bottons

@chrmarti chrmarti added the a11ymas Issue from accessibility team label Oct 2, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 16, 2018
@isidorn isidorn added macos Issues with VS Code on MAC/OS X windows VS Code on Windows issues and removed windows VS Code on Windows issues labels Jan 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
a11ymas Issue from accessibility team accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug macos Issues with VS Code on MAC/OS X verified Verification succeeded
Projects
None yet
Milestone
September 2018
Development

No branches or pull requests
6 participants
@roblourens @bpasero @jrieken @isidorn @chrmarti @AccessibilityTestingTeam-TCS