Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Outline "follow cursor" doesn't follow cursor during or after 'find' #53030

Closed
roblourens opened this issue Jun 26, 2018 · 2 comments
Closed

Outline "follow cursor" doesn't follow cursor during or after 'find' #53030

roblourens opened this issue Jun 26, 2018 · 2 comments
Assignees
@jrieken
Labels
bug Issue identified by VS Code Team member as probable bug outline Source outline view issues verified Verification succeeded
Milestone
June 2018

Comments

@roblourens
Copy link
Member

Testing #52799

  • Open fontInfo.ts in vscode
  • Enable "Follow Cursor"
  • ctrl+f, type _string
  • Press enter to go through the 3 matches
  • The current match should be selected in the Outline view, but it still shows whatever it showed before ctrl+f 馃悰
  • When function _string is the current match, press 'esc'
  • The Outline view still doesn't select _string until I move the cursor
@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug outline Source outline view issues labels Jun 27, 2018
@jrieken jrieken added this to the June 2018 milestone Jun 27, 2018
@jrieken
Copy link
Member

jrieken commented Jun 27, 2018

We have an explicit check that revealing only happens when selection changes were made explicitly e.reason === CursorChangeReason.Explicit. I'll remove that and we'll see how it feels

jrieken added a commit that referenced this issue Jun 27, 2018
@jrieken
check that document is still good to use, #53030
a1f2a57
@isidorn isidorn added the verified Verification succeeded label Jun 28, 2018
@isidorn
Copy link
Contributor

isidorn commented Jun 28, 2018

Adding verified since @roblourens exampe works now, not sure if that is the best strategy, I guess we will find out over time.

@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 11, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
bug Issue identified by VS Code Team member as probable bug outline Source outline view issues verified Verification succeeded
Projects
None yet
Milestone
June 2018
Development

No branches or pull requests
3 participants
@roblourens @jrieken @isidorn