Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

code-insiders --status — Failed to parse header size from asar file #53194

Closed
mjbvz opened this issue Jun 28, 2018 · 1 comment
Closed

code-insiders --status — Failed to parse header size from asar file #53194

mjbvz opened this issue Jun 28, 2018 · 1 comment
Assignees
@RMacfarlane
Labels
workbench-diagnostics General VS Code built-in diagnostic issues
Milestone
July 2018

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Jun 28, 2018

While verifying #51100

Steps to Reproduce:

  1. Open the VS Code source in VS Code insiders
  2. Run code-insiders --status

Bug
See this line in the output:

Workspace Stats: 
|  Window (extensionService.ts — vscode)
[98683:0627/174825.656901:ERROR:archive.cc(163)] Failed to parse header size from /Users/matb/projects/vscode/extensions/css-language-features/server/test/pathCompletionFixtures/src/data/foo.asar
@RMacfarlane
Copy link
Contributor

From https://electronjs.org/docs/tutorial/application-packaging#using-asar-archives, the node APIs for reading directories treat asar files as virtual directories. Since the file vscode/extensions/css-language-features/server/test/pathCompletionFixtures/src/data/foo.asar is just being used for a test and isn't actually formatted as an asar file, an error is logged within the call to readdir.

I can't think of a good way to suppress it since it's being logged from electron code, so I've reformatted foo.asar instead. Other users shouldn't run into this unless their projects also have a malformed asar 😄

// cc @aeschli as an fyi

@RMacfarlane RMacfarlane added this to the July 2018 milestone Jul 5, 2018
@RMacfarlane RMacfarlane added the workbench-diagnostics General VS Code built-in diagnostic issues label Jul 5, 2018
RMacfarlane pushed a commit that referenced this issue Jul 5, 2018
Revert "Reformat test .asar file, fixes #53194"
bd95324 
This reverts commit 6891415.
@microsoft microsoft deleted a comment from konradw86 Jul 6, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 19, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@RMacfarlane RMacfarlane

Labels
workbench-diagnostics General VS Code built-in diagnostic issues
Projects
None yet
Milestone
July 2018
Development

No branches or pull requests
2 participants
@RMacfarlane @mjbvz