Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor on git index is no longer read-only #53408

Closed
roblourens opened this issue Jul 2, 2018 · 3 comments
Closed

Editor on git index is no longer read-only #53408

roblourens opened this issue Jul 2, 2018 · 3 comments
Assignees
@isidorn
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release important Issue identified as high-priority verified Verification succeeded
Milestone
June 2018

Comments

@roblourens
Copy link
Member

roblourens commented Jul 2, 2018 •
edited

  • Edit a file tracked by Git
  • Stage the file
  • In the SCM viewlet, click the file in the "staged" section to open an editor that says (Index)
  • Type in the file
  • In 1.24.1, I can't edit it because it's a read-only editor
  • In 1.25, I can type in the editor, but changes aren't actually written anywhere. If I switch away from the file and switch back, they are gone
bpasero added a commit that referenced this issue Jul 2, 2018
@bpasero
fix #53408
17a707d 
Let the base text editor model be readonly by default unless the model handle is of "untitled://".
@bpasero bpasero assigned isidorn and unassigned joaomoreno Jul 2, 2018
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority labels Jul 2, 2018
@bpasero bpasero added this to the June 2018 milestone Jul 2, 2018
bpasero added a commit that referenced this issue Jul 2, 2018
@bpasero
fix #53408
6a257f9 
Let the base text editor model be readonly by default unless the model handle is of "untitled://".
@bpasero
Copy link
Member

bpasero commented Jul 2, 2018

@isidorn please review #53418

@isidorn
Copy link
Contributor

isidorn commented Jul 2, 2018

@bpasero thanks for the fix, I will review it now.

isidorn added a commit that referenced this issue Jul 2, 2018
@isidorn
Merge pull request #53418 from Microsoft/ben/53408
26eb2a9 
fix #53408
@isidorn
Copy link
Contributor

isidorn commented Jul 2, 2018

Merged pr, closing

@isidorn isidorn closed this as completed Jul 2, 2018
bpasero added a commit that referenced this issue Jul 2, 2018
@bpasero
fix #53408 (for 1.26)
b859f0e
@bpasero bpasero added the candidate Issue identified as probable candidate for fixing in the next release label Jul 3, 2018
@isidorn isidorn added the verified Verification succeeded label Jul 3, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@isidorn isidorn

Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release important Issue identified as high-priority verified Verification succeeded
Projects
None yet
Milestone
June 2018
Development

No branches or pull requests
4 participants
@joaomoreno @roblourens @bpasero @isidorn