Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Git: commit box grabs focus after reload #53419

Closed
bpasero opened this issue Jul 2, 2018 · 5 comments
Closed

Git: commit box grabs focus after reload #53419

bpasero opened this issue Jul 2, 2018 · 5 comments
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug scm General SCM compound issues verified Verification succeeded
Milestone
July 2018

Comments

@bpasero
Copy link
Member

bpasero commented Jul 2, 2018

Steps to Reproduce:

  1. open SCM viewlet
  2. focus into the editor
  3. reload window

=> focus ends up in the git commit box

Any other view does not steal focus from the editor, so it must be something in the SCM viewlet that passes DOM focus to the commit field.
@joaomoreno joaomoreno added this to the July 2018 milestone Jul 2, 2018
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug scm General SCM compound issues labels Jul 2, 2018
@itamark
Copy link
Contributor

itamark commented Jul 10, 2018 •
edited

@joaomoreno okay if I take this one as well?
I'm on a roll.

@joaomoreno
Copy link
Member

@itamark Be my guest!

@itamark
Copy link
Contributor

itamark commented Jul 10, 2018

@bpasero Interesting. I was able to reproduce in my regular Insiders build but not in my vscode dev build. Have you seen cases where this doesn't happen?

@joaomoreno
Copy link
Member

Maybe you have multiple repositories in your insiders, but not in dev?

@itamark
Copy link
Contributor

itamark commented Jul 27, 2018

Ah I was just about to commit and see it's already dealt with. I'll grab something else.

@mjbvz mjbvz added the verified Verification succeeded label Aug 2, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug scm General SCM compound issues verified Verification succeeded
Projects
None yet
Milestone
July 2018
Development

No branches or pull requests
4 participants
@joaomoreno @bpasero @itamark @mjbvz