Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't build locally anymore #53445

Closed
dbaeumer opened this issue Jul 2, 2018 · 11 comments
Closed

Can't build locally anymore #53445

dbaeumer opened this issue Jul 2, 2018 · 11 comments
Assignees
@roblourens
Labels
important Issue identified as high-priority search Search widget and operation issues vscode-build VS Code build process issues
Milestone
July 2018

Comments

@dbaeumer
Copy link
Member

dbaeumer commented Jul 2, 2018 •
edited

I get the following exception when building locally using npm run gulp vscode-win32-x64. Reason is that for some Search features a tag 1.25.0 is expected but we upgraded already to insider 1.26 and 1.25 isn't tag yet. We should at least not fail the build completely in this case.

[15:22:05] Error: Failed to find git tag for base version, 1.25.0
    at getLatestTagFromBase (C:\Users\dirkb\Projects\mseng\VSCode\vscode\build\lib\util.js:234:19)
    at Object.getPreviousVersion (C:\Users\dirkb\Projects\mseng\VSCode\vscode\build\lib\util.js:254:16)
    at getSettingsSearchBuildId (C:\Users\dirkb\Projects\mseng\VSCode\vscode\build\gulpfile.vscode.js:492:24)
    at Gulp.<anonymous> (C:\Users\dirkb\Projects\mseng\VSCode\vscode\build\gulpfile.vscode.js:268:33)
    at module.exports (C:\Users\dirkb\Projects\mseng\VSCode\vscode\node_modules\orchestrator\lib\runTask.js:34:7)
    at Gulp.Orchestrator._runTask (C:\Users\dirkb\Projects\mseng\VSCode\vscode\node_modules\orchestrator\index.js:273:3)
    at Gulp.Orchestrator._runStep (C:\Users\dirkb\Projects\mseng\VSCode\vscode\node_modules\orchestrator\index.js:214:10)
    at C:\Users\dirkb\Projects\mseng\VSCode\vscode\node_modules\orchestrator\index.js:279:18
    at finish (C:\Users\dirkb\Projects\mseng\VSCode\vscode\node_modules\orchestrator\lib\runTask.js:21:8)
    at C:\Users\dirkb\Projects\mseng\VSCode\vscode\node_modules\orchestrator\lib\runTask.js:52:4
@vscodebot vscodebot bot assigned mjbvz Jul 2, 2018
@vscodebot vscodebot bot added the javascript JavaScript support issues label Jul 2, 2018
@dbaeumer
Copy link
Member Author

dbaeumer commented Jul 2, 2018

@roblourens assigning to you since this is around search.

@dbaeumer dbaeumer added search Search widget and operation issues and removed javascript JavaScript support issues labels Jul 2, 2018
@dbaeumer dbaeumer assigned roblourens and unassigned mjbvz Jul 2, 2018
@dbaeumer
Copy link
Member Author

dbaeumer commented Jul 2, 2018

@joaomoreno FYI

@joaomoreno
Copy link
Member

@roblourens We've also hit this when building forks for VS Code on branches other than master. Can you make this a little bit more fault tolerant?

@joaomoreno joaomoreno added important Issue identified as high-priority vscode-build VS Code build process issues broken-build labels Jul 2, 2018
@joaomoreno
Copy link
Member

I had to push this in order to get a build running: 8766883

joaomoreno added a commit that referenced this issue Jul 2, 2018
@joaomoreno
be careful with getSettingsSearchBuildId
8766883 
related to #53445
@roblourens
Copy link
Member

It should break the build for real builds that we will release. But it can be skipped for others. How can I tell the difference?

@roblourens
Copy link
Member

I could change it to count from the release branch, instead of the tag.

@roblourens
Copy link
Member

Actually I'll just check for process.env.BUILD_SOURCEBRANCH like I already do for the upload step.

@roblourens
Copy link
Member

Oh, I see that this is really about the gap between incrementing the package.json and tagging, not local builds.

@roblourens roblourens reopened this Jul 2, 2018
@roblourens roblourens reopened this Jul 2, 2018
@roblourens roblourens added this to the July 2018 milestone Jul 3, 2018
@roblourens
Copy link
Member

I have a better fix which simplifies this whole process, but makes the generated build id longer. First I need to test it with my Bing counterpart to make sure it's handled ok on their end.

@joaomoreno
Copy link
Member

Mac builds are failing now: https://monacotools.visualstudio.com/Monaco/_build/results?buildId=40052&view=logs

@roblourens
Copy link
Member

Looks like that build did happen before the release was tagged. When I'm back in the office I'm going to change this so it won't depend on git tags at all.

@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 22, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
important Issue identified as high-priority search Search widget and operation issues vscode-build VS Code build process issues
Projects
None yet
Milestone
July 2018
Development

No branches or pull requests
4 participants
@joaomoreno @roblourens @dbaeumer @mjbvz