Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Now, Jade has been renamed to Pug #5381

Closed
mizunashi-mana opened this issue Apr 16, 2016 · 6 comments
Closed

Now, Jade has been renamed to Pug #5381

mizunashi-mana opened this issue Apr 16, 2016 · 6 comments
Assignees

Comments

@mizunashi-mana
Copy link

  • VSCode Version: 1.0.0
  • OS Version: Windows 10

Steps to Reproduce:

  • Open any pug file without syntax highlighting

Unfortunately, Jade has been renamed to Pug (ref: pugjs/pug#2184).
We should change jade to pug on all documents, extensions and supports...

Do you have any plans?

@mizunashi-mana
Copy link
Author

P.S. I left a solution regarding syntax highlighting on this issue for all vscode and pug user.

Add your User settings (Command Palette -> Preferences: Open User Settings -> edit settings.json) such as:

"files.associations": {
  "*.pug": "jade"
}

@egamma
Copy link
Member

egamma commented Apr 17, 2016

@gregvanl can you update the doc accordingly.
@aeschli I suggest we support both the .pug and .jade file associations.

@bgse
Copy link
Contributor

bgse commented Apr 17, 2016

Definitely keep supporting the now-legacy .jade associations, there is a lot of code floating around still including the old jade, in fact depending on generator versions people use (thinking about express-generator here, possibly others as well), there might actually be new projects coming up using the old jade for quite some time.

@aeschli
Copy link
Contributor

aeschli commented Apr 20, 2016

  • added the '.pug' file association
  • once the new name is established and e.g. the pug-lang.com website is up and ready, we can also rename the extension, the label and the language id.

@Jack-Works
Copy link
Contributor

Um, so what about do the same here?
https://github.com/Microsoft/vscode/blob/2f76c44632b0d47ba97f66fbc158c763628e30b3/extensions/jade/syntaxes/Jade.json#L5
Change it to "name": "Pug" or something

@aeschli
Copy link
Contributor

aeschli commented Jan 31, 2017

Also renamed extension and label. Kept languageID for backward compatibility. See #18219

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants