Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dash in snippets prefix broken #53945

Closed
Yago opened this issue Jul 10, 2018 · 3 comments
Closed

Dash in snippets prefix broken #53945

Yago opened this issue Jul 10, 2018 · 3 comments
Assignees
@jrieken
Labels
bug Issue identified by VS Code Team member as probable bug snippets verified Verification succeeded
Milestone
July 2018

Comments

@Yago
Copy link

Yago commented Jul 10, 2018

Since the May or the June release, the snippets containing a dash (-) inside cannot be used when fully typed.

  • VSCode Version: 1.25.0
  • OS Version: MacOS 10.13.5

Steps to Reproduce:

  1. Create a user snippet with a prefix containing a dash (-) inside
  2. Try to use it
  3. (Define "editor.snippetSuggestions": "top" in your settings to show it on top)

snippets
@jrieken jrieken added the bug Issue identified by VS Code Team member as probable bug label Jul 11, 2018
@jrieken
Copy link
Member

jrieken commented Jul 11, 2018

Nice find @Yago. This is a regression from #37166 - we now re-compute snippets when a trigger character is hit and in css, dash (-) seems to be such a character. The issue is that in the presence of a trigger character selecting snippets is more strict.

@jrieken jrieken added this to the July 2018 milestone Jul 11, 2018
@Yago
Copy link
Author

Yago commented Jul 11, 2018

Ok nice to know. Happy to help 😄

jrieken added a commit that referenced this issue Jul 12, 2018
@jrieken
change how snippet suggestions are computed, #53945
827d5ae
@jrieken
Copy link
Member

jrieken commented Jul 12, 2018

Ok, I have pushed a bigger change is how snippets are computed. That change fixes this issue and should make snippet suggestions be more stable in general. Tho, there might be some oversights and I would really appreciate more feedback. You can try my fix and change with next insiders (in ~24hr from now): https://code.visualstudio.com/insiders/

@jrieken jrieken closed this as completed Jul 12, 2018
@mjbvz mjbvz added the verified Verification succeeded label Aug 2, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Aug 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
bug Issue identified by VS Code Team member as probable bug snippets verified Verification succeeded
Projects
None yet
Milestone
July 2018
Development

No branches or pull requests
4 participants
@jrieken @Yago @Tyriar @mjbvz