Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Context view doesn't layout content #54075

Closed
jrieken opened this issue Jul 11, 2018 · 2 comments
Closed

Context view doesn't layout content #54075

jrieken opened this issue Jul 11, 2018 · 2 comments
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
July 2018

Comments

@jrieken
Copy link
Member

jrieken commented Jul 11, 2018

See attached screen shot. My expectation is that the context view checks the size of its children and positions them so that they fit into the screen, e.g moves them left a little in this case.

screen shot 2018-07-11 at 17 49 50
@jrieken jrieken added the bug Issue identified by VS Code Team member as probable bug label Jul 11, 2018
@joaomoreno joaomoreno added this to the July 2018 milestone Jul 12, 2018
@joaomoreno
Copy link
Member

joaomoreno commented Jul 18, 2018 •
edited

@jrieken The breadcrumb picker was positioned absolute, so it wasn't in the layout tree. Check the fix and whether it breaks any other assumptions you had because of position: absolute.

@jrieken
Copy link
Member Author

jrieken commented Jul 18, 2018

Yeah, that was oversight to still have them. I have added to because when the context view wasn't in the workbench subtree, adding the the monaco-workbench style would conflict with the context view styles...

@octref octref added the verified Verification succeeded label Aug 2, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 1, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
July 2018
Development

No branches or pull requests
3 participants
@joaomoreno @jrieken @octref