You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In Stable, when calling applyEdit multiple times before the first one is complete, subsequent calls are rejected, until the first edit is completes. This allows you to make the assertion that if an applyEdit succeeds, there should be one, and only one, onDidChangeTextDocument change event containing the edits that were applied.
This is not true in Insiders -- both applyEdit calls will succeed, and there will be multiple onDidChangeTextDocument events raised.
Attached is an example extension that has one command -- minibash.concurrentBash that will show the repro.
Note, that if you remove the return false; on line 69 in doEditsUntilBad, you'll see that Insiders will happly apply 1000 edits. Stable does not; it immediately fails on the second edit (As expected)
The text was updated successfully, but these errors were encountered:
The gist of it is that the version id is checked and then asynchronously the edits are applied. We should check the version id right before applying the edits...
In Stable, when calling
applyEdit
multiple times before the first one is complete, subsequent calls are rejected, until the first edit is completes. This allows you to make the assertion that if anapplyEdit
succeeds, there should be one, and only one,onDidChangeTextDocument
change event containing the edits that were applied.This is not true in Insiders -- both
applyEdit
calls will succeed, and there will be multipleonDidChangeTextDocument
events raised.Attached is an example extension that has one command --
minibash.concurrentBash
that will show the repro.Expected Debug console output w/ Stable:
Output w/ Insiders:
To run this:
Minibash: Concurrently Bash
Minibash.zip
Note, that if you remove the
return false;
on line 69 indoEditsUntilBad
, you'll see that Insiders will happly apply 1000 edits. Stable does not; it immediately fails on the second edit (As expected)The text was updated successfully, but these errors were encountered: