Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserve editor group widths when moving groups left/right #55313

Closed
axefrog opened this issue Jul 28, 2018 · 2 comments
Closed

Preserve editor group widths when moving groups left/right #55313

axefrog opened this issue Jul 28, 2018 · 2 comments
Assignees
@joaomoreno
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded workbench-editor-grid Grid layout issues in the editor area
Milestone
September 2018

Comments

@axefrog
Copy link

axefrog commented Jul 28, 2018

  • VSCode Version: 1.25.1, 1.26.0-insider
  • OS Version: Windows 10

Steps to Reproduce:

  1. Open a bunch of tabs
  2. Split a tab to make a group to the left or right
  3. Resize the divider between the two groups
  4. Move the active group to the left or right
  5. Group widths are not maintained (group size should move with group)

Does this issue occur when all extensions are disabled?: Yes
@vscodebot
Copy link

vscodebot bot commented Jul 28, 2018

(Experimental duplicate detection)
Thanks for submitting this issue. Please also check if it is already covered by an existing one, like:

@kieferrm kieferrm added the workbench-editor-grid Grid layout issues in the editor area label Jul 30, 2018
@bpasero bpasero changed the title Move editor group left/right discards group widths Preserve editor group widths when moving groups left/right Aug 6, 2018
@bpasero bpasero added the feature-request Request for new features or functionality label Aug 6, 2018
@bpasero bpasero removed their assignment Aug 6, 2018
@bpasero
Copy link
Member

bpasero commented Aug 7, 2018 •
edited

/cc @joaomoreno this may require some additional API on the grid widget for me to call. Currently I am doing this:

If I had a method to move a view to a new location the widget could maybe preserve its sizes? I see we have swapViews already, but this would be a bit different.

@joaomoreno joaomoreno self-assigned this Aug 7, 2018
@joaomoreno joaomoreno added this to the August 2018 milestone Aug 7, 2018
@joaomoreno joaomoreno added verification-needed Verification of issue is requested and removed verification-needed Verification of issue is requested labels Aug 27, 2018
@joaomoreno joaomoreno added the verification-needed Verification of issue is requested label Sep 24, 2018
@isidorn isidorn added the verified Verification succeeded label Sep 25, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded workbench-editor-grid Grid layout issues in the editor area
Projects
None yet
Milestone
September 2018
Development

No branches or pull requests
5 participants
@joaomoreno @axefrog @bpasero @isidorn @kieferrm