VS Code Insiders (Users) not opening #55353

mittalyashu · 2018-07-30T08:32:48Z

Visual Studio Code - Insiders (User): 1.26.0
OS Version: Windows 10

Steps to Reproduce:

Download the VS Code Insiders (Users)
Open the Insider build

guiohm · 2018-07-30T14:39:15Z

Same here. (also from command line)

code --version
1.26.0-insider
19df280c7f7cf73d9bafcde82a9e93b14026cfc2
x64

code --verbose

[main 16:42:52] Starting VS Code
[main 16:42:52] from: c:\Program Files\Microsoft VS Code Insiders\resources\app
[main 16:42:52] args: { _: [],
  help: false,
  h: false,
  version: false,
  v: false,
  wait: false,
  w: false,
  diff: false,
  d: false,
  add: false,
  a: false,
  goto: false,
  g: false,
  'new-window': false,
  n: false,
  'unity-launch': false,
  'reuse-window': false,
  r: false,
  'open-url': false,
  performance: false,
  p: false,
  'prof-startup': false,
  verbose: true,
  logExtensionHostCommunication: false,
  'disable-extensions': false,
  disableExtensions: false,
  'list-extensions': false,
  'show-versions': false,
  nolazy: false,
  issue: false,
  'skip-getting-started': false,
  'skip-release-notes': false,
  'sticky-quickopen': false,
  'disable-restore-windows': false,
  'disable-telemetry': false,
  'disable-updates': false,
  'disable-crash-reporter': false,
  'skip-add-to-recently-opened': false,
  status: false,
  s: false,
  'file-write': false,
  'file-chmod': false,
  'driver-verbose': false }
[main 16:42:52] Resolving machine identifier...
[main 16:42:52] Resolved machine identifier: 7897084c9bb5bf07f6358da2c131bbd5d059a274ac7e66938f97669af55a19e4
[main 16:42:52] update#setState idle
[main 16:42:52] TypeError: Cannot read property 'lastIndexOf' of undefined
    at Object.o [as basename] (C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\code\electron-main\main.js:46:538)
    at Object.t.getWorkspaceLabel (C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\code\electron-main\main.js:333:194)
    at e.createOpenRecentMenuItem (C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\code\electron-main\main.js:365:142)
    at e.setOpenRecentMenu (C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\code\electron-main\main.js:364:326)
    at e.setFileMenu (C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\code\electron-main\main.js:360:923)
    at e.install (C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\code\electron-main\main.js:356:524)
    at new e (C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\code\electron-main\main.js:353:177)
    at t.create (C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\code\electron-main\main.js:52:365)
    at e._createInstance (C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\code\electron-main\main.js:207:10)
    at e.createInstance (C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\code\electron-main\main.js:206:269)
    at t.afterWindowOpen (C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\code\electron-main\main.js:519:137)
    at C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\code\electron-main\main.js:514:275
    at e.invokeFunction (C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\code\electron-main\main.js:205:920)
    at C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\code\electron-main\main.js:514:239
    at n.Class.define.cancel.then (C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\code\electron-main\main.js:90:201)
    at C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\code\electron-main\main.js:514:99
    at n.Class.define.cancel.then (C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\code\electron-main\main.js:90:201)
    at t.startup (C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\code\electron-main\main.js:513:488)
    at C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\code\electron-main\main.js:525:131
    at Object.v [as _notify] (C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\code\electron-main\main.js:83:572)
    at Object.enter (C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\code\electron-main\main.js:86:924)
    at n.Class.derive._oncancel._run (C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\code\electron-main\main.js:88:790)
    at n.Class.derive._oncancel._completed (C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\code\electron-main\main.js:88:231)
    at Server.<anonymous> (C:\Program Files\Microsoft VS Code Insiders\resources\app\out\vs\code\electron-main\main.js:168:908)
    at Object.onceWrapper (events.js:293:19)
    at emitNone (events.js:86:13)
    at Server.emit (events.js:188:7)
    at emitListeningNT (net.js:1290:10)
    at _combinedTickCallback (internal/process/next_tick.js:77:11)
    at process._tickCallback (internal/process/next_tick.js:104:9)
[main 16:42:52] Lifecycle#kill()
[main 16:42:52] Lifecycle#window-closed 1
[main 16:42:52] Lifecycle#onShutdown.fire()

pdfowler · 2018-07-30T17:21:04Z

On MacOS too :

Applications pdfowler$ ./Visual\ Studio\ Code\ -\ Insiders.app/Contents/MacOS/Electron --verbose
[main 10:20:08 AM] Starting VS Code
[main 10:20:08 AM] from: /Applications/Visual Studio Code - Insiders.app/Contents/Resources/app
[main 10:20:08 AM] args: { _: [],
  help: false,
  h: false,
  version: false,
  v: false,
  wait: false,
  w: false,
  diff: false,
  d: false,
  add: false,
  a: false,
  goto: false,
  g: false,
  'new-window': false,
  n: false,
  'unity-launch': false,
  'reuse-window': false,
  r: false,
  'open-url': false,
  performance: false,
  p: false,
  'prof-startup': false,
  verbose: true,
  logExtensionHostCommunication: false,
  'disable-extensions': false,
  disableExtensions: false,
  'list-extensions': false,
  'show-versions': false,
  nolazy: false,
  issue: false,
  'skip-getting-started': false,
  'skip-release-notes': false,
  'sticky-quickopen': false,
  'disable-restore-windows': false,
  'disable-telemetry': false,
  'disable-updates': false,
  'disable-crash-reporter': false,
  'skip-add-to-recently-opened': false,
  status: false,
  s: false,
  'file-write': false,
  'file-chmod': false,
  'driver-verbose': false }
[main 10:20:08 AM] Resolving machine identifier...
[main 10:20:08 AM] Resolved machine identifier: 75981006e5caffec60741792b31b0563aaa20fb42a70405229a457d78aa456bb
[main 10:20:08 AM] update#setState idle
[main 10:20:08 AM] TypeError: Cannot read property 'length' of undefined
    at e.getRecentlyOpenedFromStorage (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:378:354)
    at e.getRecentlyOpened (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:377:582)
    at e.insertRecentMenuItems (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:368:537)
    at e.setFallbackMenuById (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:365:925)
    at e.setFallbackMenuById (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:365:626)
    at e.install (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:361:76)
    at e (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:359:218)
    at t.create (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:52:694)
    at e._createInstance (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:209:10)
    at e.createInstance (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:208:269)
    at e (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:380:442)
    at t.create (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:52:694)
    at e._createInstance (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:209:10)
    at e._createAndCacheServiceInstance (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:209:957)
    at e._getOrCreateServiceInstance (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:209:147)
    at Object.get (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:207:794)
    at t.openFirstWindow (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:488:769)
    at /Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:486:363
    at e.invokeFunction (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:207:920)
    at /Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:486:327
    at n.Class.define.cancel.then (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:91:201)
    at /Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:486:246
    at n.Class.define.cancel.then (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:91:201)
    at t.startup (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:485:604)
    at /Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:497:539
    at Object.v [as _notify] (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:84:572)
    at Object.enter (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:87:924)
    at n.Class.derive._oncancel._run (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:89:790)
    at n.Class.derive._oncancel._completed (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:89:231)
    at Server.<anonymous> (/Applications/Visual Studio Code - Insiders.app/Contents/Resources/app/out/vs/code/electron-main/main.js:170:657)
    at Object.onceWrapper (events.js:313:30)
    at emitNone (events.js:106:13)
    at Server.emit (events.js:208:7)
    at emitListeningNT (net.js:1378:10)
    at _combinedTickCallback (internal/process/next_tick.js:135:11)
    at process._tickCallback (internal/process/next_tick.js:180:9)
[main 10:20:08 AM] Lifecycle#kill()
[main 10:20:08 AM] telemetry/optInStatus { optIn: true }

isidorn · 2018-07-30T18:44:42Z

Seems to be an null pointer when reading the recently opened list to populate the menu. Assigning to @sbatten
There is a slight chance this the uri label work I did, but looking at the stack trace it looks like the menu.

sbatten · 2018-07-30T21:55:37Z

@isidorn The second stack shows a crash in a function with no parameters passed from the menubar. Did your work affect the HistoryMainService?

isidorn · 2018-07-31T13:29:04Z

@sbatten my work changed the HistoryMainService such that it now depends on the UriDisplayService. However this should not affect this error.

Stack trace 2 points the following:
The issue seems to be in the getRecentlyOpenedFromStorage - storedRecents.workspaces is undefined and that method was heavily changed with refactoring done by @sandy081
Due to that also assigning to @aeschli and @sandy081 to investigate if the workspace path refactoring broke this as I believe.

Stack trace 1 points the following:
Here you are passing a workspace which has a configPath undefined. This seems invalid

@mittalyashu can you please also attach your stack trace if you start vscode verbose as the other two users. Thanks a lot

mittalyashu · 2018-08-01T07:56:53Z

stack trace if you start vscode verbose.

And, how to do that?

mittalyashu · 2018-08-01T07:58:06Z

@aeschli, can we try downloading and installing the VS Code Insider (Users), due to this changes 77d90a9

isidorn · 2018-08-01T13:15:45Z

The insiders from today should have a fix for this.
@mittalyashu @guiohm @pdfowler can you please verify if the issue is fixed for you? Thank you

pdfowler · 2018-08-01T18:29:51Z

@isidorn Works for me! Many thanks! 🎉

isidorn · 2018-08-02T09:57:16Z

@pdfowler great, adding verified label

mittalyashu · 2018-08-02T10:04:33Z

The update works for me too.

isidorn added important Issue identified as high-priority bug Issue identified by VS Code Team member as probable bug labels Jul 30, 2018

isidorn assigned sbatten Jul 30, 2018

isidorn added the workbench-menu label Jul 30, 2018

isidorn added this to the July 2018 milestone Jul 30, 2018

sbatten assigned isidorn Jul 30, 2018

isidorn assigned aeschli and sandy081 Jul 31, 2018

aeschli closed this as completed in 77d90a9 Jul 31, 2018

isidorn added the verified Verification succeeded label Aug 2, 2018

vscodebot bot locked and limited conversation to collaborators Sep 14, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

VS Code Insiders (Users) not opening #55353

VS Code Insiders (Users) not opening #55353

mittalyashu commented Jul 30, 2018 •

edited

guiohm commented Jul 30, 2018 •

edited

pdfowler commented Jul 30, 2018

isidorn commented Jul 30, 2018

sbatten commented Jul 30, 2018

isidorn commented Jul 31, 2018

mittalyashu commented Aug 1, 2018

mittalyashu commented Aug 1, 2018

isidorn commented Aug 1, 2018

pdfowler commented Aug 1, 2018

isidorn commented Aug 2, 2018

mittalyashu commented Aug 2, 2018

VS Code Insiders (Users) not opening #55353

VS Code Insiders (Users) not opening #55353

Comments

mittalyashu commented Jul 30, 2018 • edited

guiohm commented Jul 30, 2018 • edited

pdfowler commented Jul 30, 2018

isidorn commented Jul 30, 2018

sbatten commented Jul 30, 2018

isidorn commented Jul 31, 2018

mittalyashu commented Aug 1, 2018

mittalyashu commented Aug 1, 2018

isidorn commented Aug 1, 2018

pdfowler commented Aug 1, 2018

isidorn commented Aug 2, 2018

mittalyashu commented Aug 2, 2018

mittalyashu commented Jul 30, 2018 •

edited

guiohm commented Jul 30, 2018 •

edited