Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Streamline terminology for switching a diff editor into inline mode #55397

Closed
kieferrm opened this issue Jul 30, 2018 · 2 comments
Closed

Streamline terminology for switching a diff editor into inline mode #55397

kieferrm opened this issue Jul 30, 2018 · 2 comments
Assignees
@bpasero
Labels
diff-editor Diff editor mode issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Milestone
September 2018

Comments

@kieferrm
Copy link
Member

From
#54967 (comment):

  1. GUI toggle: Toggle Inline View
  2. Setting switch: renderSidebySide
  3. Keyboard toggle: editorMode.
@alexdima alexdima added the diff-editor Diff editor mode issues label Jul 31, 2018
@alexdima alexdima added the feature-request Request for new features or functionality label Sep 12, 2018
@alexdima
Copy link
Member

  1. ✅ I've changed the GUI toggle: Toggle Side By Side View
  2. ✅ I've left unchanged in Settings (avoid migration): diffEditor.renderSideBySide
  3. I suggest we add a new command and leave the old one doing the same thing for keybinding compatibility purposes. @bpasero You introduced toggle.diff.editorMode, what id would you suggest to better align with the other two names?

@alexdima alexdima assigned bpasero and unassigned alexdima Sep 22, 2018
alexdima added a commit that referenced this issue Sep 22, 2018
@alexdima
Rename the GUI command title (#55397)
bce88d3
@bpasero bpasero added this to the September 2018 milestone Sep 23, 2018
@bpasero
Copy link
Member

bpasero commented Sep 25, 2018

I added toggle.diff.renderSideBySide and deprecated the old one.

@bpasero bpasero closed this as completed Sep 25, 2018
@bpasero bpasero added the verification-needed Verification of issue is requested label Sep 25, 2018
bpasero added a commit that referenced this issue Sep 25, 2018
@bpasero
fix #55397
802bd40
@isidorn isidorn added the verified Verification succeeded label Sep 25, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bpasero bpasero

Labels
diff-editor Diff editor mode issues feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
September 2018
Development

No branches or pull requests
4 participants
@bpasero @isidorn @kieferrm @alexdima