Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings editor - TOC and settings list tab order reversed #55799

Closed
roblourens opened this issue Aug 3, 2018 · 0 comments
Closed

Settings editor - TOC and settings list tab order reversed #55799

roblourens opened this issue Aug 3, 2018 · 0 comments
Assignees
@roblourens
Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues verified Verification succeeded
Milestone
September 2018

Comments

@roblourens
Copy link
Member

  • Focus a setting
  • tab
  • TOC is focused

It should be left -> right

This came from changes to get the shadow to be full width. If the TOC comes first in the DOM, then the settings' ScrollableElement intercepts scroll events over the TOC. So I reversed the DOM order but there's probably a better fix. Or, we get rid of the shadow.
@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues settings-editor VS Code settings editor issues labels Aug 3, 2018
@roblourens roblourens added this to the August 2018 milestone Aug 3, 2018
@roblourens roblourens self-assigned this Aug 3, 2018
@roblourens roblourens mentioned this issue Aug 3, 2018
Closed
38 tasks
@aeschli aeschli added the verified Verification succeeded label Sep 27, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues verified Verification succeeded
Projects
None yet
Milestone
September 2018
Development

No branches or pull requests
2 participants
@roblourens @aeschli