Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"We recommend switching to our new User Setup ..." always pops up regardless of the fact whether it new setup was already installed or not #55840

Closed
zpdDG4gta8XKpMCd opened this issue Aug 5, 2018 · 36 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release install-update VS Code installation and upgrade system issues verified Verification succeeded windows VS Code on Windows issues
Milestone

Comments

@zpdDG4gta8XKpMCd
Copy link

zpdDG4gta8XKpMCd commented Aug 5, 2018

Version: 1.26.0-insider
Commit: 4fa62b2
Date: 2018-08-03T12:32:37.823Z
Electron: 2.0.5
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
Architecture: x64

image

@wsmelton
Copy link

wsmelton commented Aug 6, 2018

I recall clicking on the sprocket/wheel and select the option to never show that again. I have not seen it show up after upgrades since the first release it was added.

@zpdDG4gta8XKpMCd
Copy link
Author

thats one way of doing it

@wsmelton
Copy link

wsmelton commented Aug 6, 2018

What way are you expecting?

@zpdDG4gta8XKpMCd
Copy link
Author

zpdDG4gta8XKpMCd commented Aug 6, 2018 via email

@joaomoreno
Copy link
Member

Does the popup show up in the user-installed Code instance?

@joaomoreno joaomoreno added the info-needed Issue requires more information from poster label Aug 6, 2018
@zpdDG4gta8XKpMCd
Copy link
Author

@joaomoreno that's exactly what happens

@joaomoreno
Copy link
Member

joaomoreno commented Aug 6, 2018

Can you show me the full contents of app\resources\app\product.json located in your user installed Code?

Did the setup package ask for Administrator privileges when you started it?

@zpdDG4gta8XKpMCd
Copy link
Author

it was done under an unprivileged user

here is the content:
product.txt

@joaomoreno
Copy link
Member

joaomoreno commented Aug 6, 2018

What is the name of the setup .exe you downloaded? And perhaps an MD5 hashsum of the file, if you can provide that?

@zpdDG4gta8XKpMCd
Copy link
Author

VSCodeUserSetup-x64-1.26.0-insider.exe

@zpdDG4gta8XKpMCd
Copy link
Author

D:\Downloads>D:\laptop\fciv.exe -md5 -sha1 D:\Downloads\VSCodeUserSetup-x64-1.26.0-insider.exe
//
// File Checksum Integrity Verifier version 2.05.
//
                MD5                             SHA-1
-------------------------------------------------------------------------
6d2924bff9647a62466696dba76774b0 c16397d5d8dfc6aa3e2932f3ee5d9f69e1a38b62 d:\downloads\vscodeusersetup-x64-1.26.0-insider.exe

@joaomoreno
Copy link
Member

Interesting... those hashes do not match the hash of the user setup for our version 4fa62b2, which you indicated in the first post. Can you reconfirm your VS Code version?

@zpdDG4gta8XKpMCd
Copy link
Author

man, no wonder versions don't match, i did reinstall so many times already and every time i get the same popup, hence this issue:

Version: 1.26.0-insider
Commit: 5fae91d
Date: 2018-07-25T02:04:01.629Z
Electron: 2.0.5
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
Architecture: x64

@joaomoreno
Copy link
Member

Interesting... version 5fae91d also has different hashes for the setup file. Any chance you can upload that file somewhere I can download it from? (I am aware it is a large file).

@zpdDG4gta8XKpMCd
Copy link
Author

here are 3 different install packages that i used before i opened this issue:

https://drive.google.com/open?id=15MyfXy8CLKHaR_Aw2es48K_TDYSCRUeJ

@joaomoreno
Copy link
Member

joaomoreno commented Aug 6, 2018

And when you tried the next, did you fully uninstall the previous? Which was the last you used?

@zpdDG4gta8XKpMCd
Copy link
Author

here is the last one that i used on my very clean just reinstalled desktop:

Version: 1.26.0-insider
Commit: 4fa62b2
Date: 2018-08-03T12:32:37.823Z
Electron: 2.0.5
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
Architecture: x64

showing the same problem every time i open it:

image

@joaomoreno
Copy link
Member

I still can't reproduce...

On that clean desktop, did you ever installed the system-wide setup? How did you eventually ended up getting a user-installable setup?

@zpdDG4gta8XKpMCd
Copy link
Author

  1. i reinstalled the desktop anew

  2. i downloaded and installed VSCodeSetup-x64-1.26.0-insider.exe: https://drive.google.com/open?id=17Eqe8Tgpv1S5mCvy8eGr0vZS41gnprbX

  3. upon opening code-insiders ./ i saw this:
    image

  4. i followed the link and got VSCodeUserSetup-x64-1.26.0-insider.exe: https://drive.google.com/open?id=1QqjJWMhgtsw8lz3-M3NVi2yQbXtuWTJN

  5. i closed my code insiders and i installed the packaged downloaded at step 4

  6. i opened my code insiders again and i saw the same invitation to download and install VSCodeUserSetup-x64-1.26.0-insider.exe again

image

  1. i cam here and i opened the issue

@joaomoreno
Copy link
Member

joaomoreno commented Aug 7, 2018

i closed my code insiders and i installed the packaged downloaded at step 4

This is interesting. When you attempted to install at this step, didn't the uninstaller tell you to first uninstall the first package? Or did you simply answer Yes when it said Code - Insiders is already installed on this system for all users. Are you sure you want to install it for this user?

If you did, make sure you're launching the user Code, not the system one.

For some reason, Google Drive doesn't let me download those files... it just keeps loading until it times out.

@joaomoreno
Copy link
Member

Yeah, I see... you now have both versions installed and the system-wide one wins the race in the %PATH% variable.

@joaomoreno joaomoreno removed the info-needed Issue requires more information from poster label Aug 7, 2018
@joaomoreno
Copy link
Member

joaomoreno commented Aug 7, 2018

I'll disable the popup if I detect that both are installed. I'll also improve the popup's message to be more explicit of what's going to happen.

I suggest for you to uninstall the system-wide setup, and you'll be alright.

@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug install-update VS Code installation and upgrade system issues windows VS Code on Windows issues labels Aug 7, 2018
@joaomoreno joaomoreno added this to the July 2018 milestone Aug 7, 2018
@joaomoreno joaomoreno added the candidate Issue identified as probable candidate for fixing in the next release label Aug 7, 2018
joaomoreno added a commit that referenced this issue Aug 7, 2018
joaomoreno added a commit that referenced this issue Aug 7, 2018
@joaomoreno
Copy link
Member

Verification steps:

  1. When installing the user setup after having the system setup installed, there should be a descriptive message informing the user of potential problems if both versions are installed.
  2. When having both versions installed, the system version should warn that there's a user installed version as well.

joaomoreno added a commit that referenced this issue Aug 7, 2018
joaomoreno added a commit that referenced this issue Aug 7, 2018
joaomoreno added a commit that referenced this issue Aug 7, 2018
fixes #55840

fixes #55840

delay winreg import

related to #55840

show notification earlier

related to #55840

fix #55840

update inno setup message

related to #55840
@chrmarti chrmarti added the verified Verification succeeded label Aug 8, 2018
@zouhair
Copy link

zouhair commented Aug 14, 2018

Just updated to the 1.26 version and started getting the same message.

@szukai
Copy link

szukai commented Aug 15, 2018

Getting this either randomly whenever VS code decides to update OR whenever I decide to manually check for updates.

It does get horribly confusing.


Version: 1.26.0
Commit: 4e93618
Date: 2018-08-13T16:29:31.933Z
Electron: 2.0.5
Chrome: 61.0.3163.100
Node.js: 8.9.3
V8: 6.1.534.41
Architecture: x64

@joaomoreno
Copy link
Member

@zouhair @szukai You can click the gear icon ⚙ in the notification and choose Never Show Again.

@szukai
Copy link

szukai commented Aug 16, 2018

So.. it's working as intended?

@joaomoreno
Copy link
Member

@szukai I did not understand whether you have installed the user setup. Did you?

@szukai
Copy link

szukai commented Aug 16, 2018

@joaomoreno I apologize, I don't quite follow. I used the VSCodeUserSetup-x64-1.26.0.exe to install VSCode and it's the only copy on my machine, if that's what you're referring to.

@joaomoreno
Copy link
Member

Got it. You keep having this popup and it's definitely the only VS Code copy you have in your machine? Can you show me the contents of the resources\app\product.json file inside the installation folder?

@szukai
Copy link

szukai commented Aug 16, 2018

@joaomoreno uploaded it here: https://ufile.io/wzu6n

Well I'm the only user of this machine, so the only way it could've "not been the only copy" is if I had a previous version and there wasn't a clean uninstall I guess? I haven't tried installing VSCode via any other methods besides the installer off the site (the laziest way).

@joaomoreno
Copy link
Member

Are you absolutely sure you used VSCodeUserSetup-x64-1.26.0.exe to install the version which gave you this file? Can you send me that VSCodeUserSetup-x64-1.26.0.exe setup?

@szukai
Copy link

szukai commented Aug 16, 2018

https://ufile.io/u6pp1

@joaomoreno
Copy link
Member

joaomoreno commented Aug 17, 2018

If you open the Control Panel and go to Uninstall Programs, how many Microsoft VS Code rows do you see there?

When I install the Setup package you gave me, the product.json which gets installed is different than the one you sent me.

Did you install this over the previous one?

@szukai
Copy link

szukai commented Aug 17, 2018

image

Only one. (sorted by name)

It's possible I got the current exe I passed to you from the popup we're discussing about and haven't installed over it yet as I assumed they were the same (1.26.0) version

@joaomoreno
Copy link
Member

That installation is not the User one, since it would have (User) in the name. Thanks for the screenshot.

Uninstall that one and install the one you sent me.

@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug candidate Issue identified as probable candidate for fixing in the next release install-update VS Code installation and upgrade system issues verified Verification succeeded windows VS Code on Windows issues
Projects
None yet
Development

No branches or pull requests

7 participants
@joaomoreno @zouhair @zpdDG4gta8XKpMCd @szukai @chrmarti @wsmelton and others