Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak color names for breadcrumbs #55865

Closed
jrieken opened this issue Aug 6, 2018 · 4 comments
Closed

Tweak color names for breadcrumbs #55865

jrieken opened this issue Aug 6, 2018 · 4 comments
Assignees
@jrieken
Labels
breadcrumbs polish Cleanup and polish issue
Milestone
July 2018

Comments

@jrieken
Copy link
Member

jrieken commented Aug 6, 2018

Following up on the discussion here:
c588525#r29968874
@jrieken jrieken self-assigned this Aug 6, 2018
@jrieken jrieken added the polish Cleanup and polish issue label Aug 6, 2018
@jrieken jrieken added this to the July 2018 milestone Aug 6, 2018
@jrieken
Copy link
Member Author

jrieken commented Aug 6, 2018

/cc @bpasero

@jrieken
Copy link
Member Author

jrieken commented Aug 6, 2018

Should it be breadcrumb.pickerBackground or breadcrumbPicker.background?

@bpasero
Copy link
Member

bpasero commented Aug 6, 2018

+1 for breadcrumbPicker.background

jrieken added a commit that referenced this issue Aug 6, 2018
@jrieken
fix #55865
c2ddece
@jrieken jrieken closed this as completed in bca795f Aug 6, 2018
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug verified Verification succeeded labels Aug 6, 2018
@joaomoreno
Copy link
Member

LGTM by code review

@joaomoreno joaomoreno removed bug Issue identified by VS Code Team member as probable bug verified Verification succeeded labels Aug 6, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Sep 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
breadcrumbs polish Cleanup and polish issue
Projects
None yet
Milestone
July 2018
Development

No branches or pull requests
3 participants
@joaomoreno @bpasero @jrieken