Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Search Results show in 'Other files' w/ workspace bucketting #57720

Closed
grork opened this issue Aug 31, 2018 · 1 comment
Closed

Search Results show in 'Other files' w/ workspace bucketting #57720

grork opened this issue Aug 31, 2018 · 1 comment
Assignees
@roblourens
Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Milestone
September 2018

Comments

@grork
Copy link

grork commented Aug 31, 2018

  • VSCode Version: 1.27-insiders
  • OS Version: Windows 10 10.0.17234.228

Steps to Reproduce:

  1. Have multiple workspaces that are in a file system provider sourced URI
  2. Have one of the workspaces in protocol:/, and another in protocol:/bob
  3. Have a search provider that will provide the search results, rather than having VS code do the search
  4. Have a search result under the protocol:/ workpace

Expected behaviour:
The result will show under the correct workspace grouping

Actual result:
It shows under the 'Other Files' section. This is because here: https://github.com/Microsoft/vscode/blob/a0ce75fffb8ad610d7effffca711e5b2a93f486d/src/vs/workbench/parts/search/common/searchModel.ts#L696

It uses fsPath, so with assumptions in the matching logic, it doesn't find a match and gives up
@vscodebot vscodebot bot added the insiders label Aug 31, 2018
@roblourens roblourens added bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues labels Sep 3, 2018
@roblourens roblourens added this to the September 2018 milestone Sep 3, 2018
@roblourens
Copy link
Member

roblourens commented Sep 22, 2018 •
edited

Verification - run https://github.com/Microsoft/vscode-extension-samples/tree/roblou/searchProviderExample/fsprovider-sample, have two memfs folders in the workspace. Do a text search, verify that the results are shown in their folders correctly.

Ignore the errors from file search not being hooked up in that sample.

@chrmarti chrmarti added the verified Verification succeeded label Sep 28, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@roblourens roblourens

Labels
bug Issue identified by VS Code Team member as probable bug search Search widget and operation issues verified Verification succeeded
Projects
None yet
Milestone
September 2018
Development

No branches or pull requests
3 participants
@roblourens @grork @chrmarti