Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SCM is very chatty #57854

Closed
alexdima opened this issue Sep 4, 2018 · 2 comments
Closed

SCM is very chatty #57854

alexdima opened this issue Sep 4, 2018 · 2 comments
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug perf scm General SCM compound issues verified Verification succeeded
Milestone
September 2018

Comments

@alexdima
Copy link
Member

alexdima commented Sep 4, 2018 •
edited

Run with --logExtensionHostCommunication or with code change for LOG_EXTENSION_HOST_COMMUNICATION

  • Open a folder that uses git and has a single text file as modified
  • Open the text file
  • Have auto-save enabled
  • Type one character
    image

Observe there are very many SCM related messages even if nothing at all changes visually...

  • the status bar command is set to be the same
  • the count is set to be 1 (the same value it had before)
  • the context key gitFreshRepository is set to false (as it was before)
  • the status bar command is set to be the same x3
  • it sends a change event for file decorations (which is incorrect/imprecise, the file is still modified)
  • decorations for 6 files are fetched again due to the previous imprecise event.
  • the content (or only the URL?) of the original file is fetched again which is incorrect because the index was not changed.

screen shot 2018-09-04 at 12 12 43
@joaomoreno joaomoreno added this to the September 2018 milestone Sep 4, 2018
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug scm General SCM compound issues labels Sep 4, 2018
@joaomoreno joaomoreno changed the title Git is very very chatty SCM is very chatty Sep 14, 2018
@joaomoreno
Copy link
Member

joaomoreno commented Sep 20, 2018 •
edited

  • Status bar: SCM: status bar entries are being added > 10 times right on startup #25281
  • Count
  • Context key
  • File decorations: this is a hard one to figure out since decorations can change even if the index does not change. Can't fix this one.
  • Get original resource: unfortunately this is also a tough one. The original document uri might actually change. We can cache it given some strict conditions, but it will overcomplicate the code. Keeping this one, unless we see it's effectively affecting perf.

joaomoreno added a commit that referenced this issue Sep 20, 2018
@joaomoreno
scm: memoize count
56f9c20 
related to #57854
joaomoreno added a commit that referenced this issue Sep 20, 2018
@joaomoreno
git: cache isFreshRepository
7c2d950 
related to #57854
@alexdima
Copy link
Member Author

👍 Nice!

@mjbvz mjbvz added the verified Verification succeeded label Sep 27, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 4, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug perf scm General SCM compound issues verified Verification succeeded
Projects
None yet
Milestone
September 2018
Development

No branches or pull requests
3 participants
@joaomoreno @alexdima @mjbvz